Make client_secret_env optional in vMCP OIDC config #2803
Merged
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the requirement for client_secret_env in the vMCP config validator. This field is now optional to support OIDC flows that don't require client secrets: - PKCE flows (public clients) - OIDC Token validation without introspection - Kubernetes service account token validation This aligns with the Kubernetes CRD behavior where clientSecretRef is already optional.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
+ Coverage 56.49% 56.53% +0.04%
==========================================
Files 319 319
Lines 30954 30885 -69
==========================================
- Hits 17487 17462 -25
+ Misses 11962 11930 -32
+ Partials 1505 1493 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the requirement for client_secret_env in the vMCP config
validator. This field is now optional to support OIDC flows that
don't require client secrets:
This aligns with the Kubernetes CRD behavior where clientSecretRef
is already optional.