-
Notifications
You must be signed in to change notification settings - Fork 156
add tests for validating conflict resolution #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
afb3d71 to
5f0f00d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
=======================================
Coverage 56.57% 56.57%
=======================================
Files 320 320
Lines 30882 30882
=======================================
Hits 17470 17470
Misses 11911 11911
Partials 1501 1501 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5f0f00d to
f3e33ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive E2E tests for VirtualMCPServer conflict resolution strategies, validating how the system handles tool name conflicts when aggregating multiple MCP backends. The tests exercise three distinct conflict resolution approaches: prefix-based naming, priority-based selection, and manual overrides.
Key Changes:
- Implements test coverage for three conflict resolution strategies (Prefix, Priority, and Manual)
- Each strategy test suite validates proper tool aggregation, conflict handling, and tool invocation
- Tests verify configuration correctness and expected behavior for each resolution mechanism
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f3e33ad to
0d3aa07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/e2e/thv-operator/virtualmcp/virtualmcp_conflict_resolution_test.go
Outdated
Show resolved
Hide resolved
test/e2e/thv-operator/virtualmcp/virtualmcp_conflict_resolution_test.go
Outdated
Show resolved
Hide resolved
test/e2e/thv-operator/virtualmcp/virtualmcp_conflict_resolution_test.go
Outdated
Show resolved
Hide resolved
0d3aa07 to
88a0129
Compare
No description provided.