-
Notifications
You must be signed in to change notification settings - Fork 156
Require explicit authentication configuration in VirtualMCPServer #2865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2865 +/- ##
==========================================
- Coverage 56.66% 56.58% -0.08%
==========================================
Files 322 322
Lines 31279 31439 +160
==========================================
+ Hits 17723 17790 +67
- Misses 12038 12120 +82
- Partials 1518 1529 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c234d1d to
eb37107
Compare
eb37107 to
844fe49
Compare
ac07ac9 to
6d9beb9
Compare
jhrozek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits inline, also let's change the PR text to reflect what the PR does now, I think github uses the PR text as the commit message if you squash
6d9beb9 to
c7aa5a5
Compare
Make IncomingAuth required in VirtualMCPServer CRD to enforce explicit authentication decisions. Users must specify auth type even for anonymous. Fixes #2843
c7aa5a5 to
2c10b0c
Compare
07ede94 to
68a21b5
Compare
68a21b5 to
19ded00
Compare
Make IncomingAuth required in VirtualMCPServer CRD to enforce explicit
authentication decisions. Users must specify auth type even for anonymous.
Fixes #2843
🤖 Generated with Claude Code