Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Dec 3, 2025

Make IncomingAuth required in VirtualMCPServer CRD to enforce explicit
authentication decisions. Users must specify auth type even for anonymous.

Fixes #2843

🤖 Generated with Claude Code

@yrobla yrobla requested review from JAORMX and jhrozek December 3, 2025 11:12
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.58%. Comparing base (a5ff43f) to head (19ded00).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
- Coverage   56.66%   56.58%   -0.08%     
==========================================
  Files         322      322              
  Lines       31279    31439     +160     
==========================================
+ Hits        17723    17790      +67     
- Misses      12038    12120      +82     
- Partials     1518     1529      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yrobla yrobla requested review from amirejaz and rdimitrov December 3, 2025 11:30
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Dec 3, 2025
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits inline, also let's change the PR text to reflect what the PR does now, I think github uses the PR text as the commit message if you squash

@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
Make IncomingAuth required in VirtualMCPServer CRD to enforce explicit
authentication decisions. Users must specify auth type even for anonymous.

Fixes #2843
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
@yrobla yrobla changed the title Default VirtualMCPServer incomingAuth to anonymous Require explicit authentication configuration in VirtualMCPServer Dec 3, 2025
amirejaz
amirejaz previously approved these changes Dec 3, 2025
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
@yrobla yrobla requested review from amirejaz and jhrozek December 3, 2025 15:25
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Dec 3, 2025
@yrobla yrobla merged commit 90a7b31 into main Dec 4, 2025
48 of 50 checks passed
@yrobla yrobla deleted the fix/issue-2843 branch December 4, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VirtualMCPServer crashes without incomingAuth - should require or default to anonymous

5 participants