From af2fadd444ed78994bbc5afd594f0a899c631bf4 Mon Sep 17 00:00:00 2001 From: Mauro Ezequiel Moltrasio Date: Mon, 4 May 2026 10:41:04 +0200 Subject: [PATCH 1/3] fix: install cargo-about with --features=cli With release 0.9 of cargo-about it is now required to specify the cli feature for it to be properly installed as an executable binary. If said feature is not added, installation fails with the message: ``` warning: none of the package's binaries are available for install using the selected features bin "cargo-about" requires the features: `cli` Consider enabling some of the needed features by passing, e.g., `--features="cli"` ``` There is also a bit of cleaning up, namely we add `THIRD_PARTY_LICENSES.html` to the list of ignored files and make sure that `make clean` removes it. --- .github/workflows/license-checks.yml | 2 +- .gitignore | 1 + Makefile | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/license-checks.yml b/.github/workflows/license-checks.yml index 08f93726..aefe6a98 100644 --- a/.github/workflows/license-checks.yml +++ b/.github/workflows/license-checks.yml @@ -46,7 +46,7 @@ jobs: key: check-license-${{ runner.os }} - name: Install cargo-about - run: cargo install cargo-about + run: cargo install cargo-about --features=cli - name: Generate licenses run: make licenses diff --git a/.gitignore b/.gitignore index 624a65d1..77d04df7 100644 --- a/.gitignore +++ b/.gitignore @@ -18,6 +18,7 @@ internalapi/ # Files generated by tests results.xml logs/ +THIRD_PARTY_LICENSES.html # clangd and compilation database .cache/ diff --git a/Makefile b/Makefile index fb47f6cb..55f58098 100644 --- a/Makefile +++ b/Makefile @@ -23,7 +23,7 @@ image: licenses:THIRD_PARTY_LICENSES.html THIRD_PARTY_LICENSES.html:Cargo.lock - cargo install cargo-about + $(if $(shell command -v cargo-about),,$(error cargo-about not found, you can install it with 'cargo install cargo-about --features=cli')) cargo about generate --format handlebars -o THIRD_PARTY_LICENSES.html about_html.hbs integration-tests: @@ -34,6 +34,7 @@ performance-tests: clean: make -C tests clean + rm -f THIRD_PARTY_LICENSES.html format-check: cargo fmt --check From e9f20b69d815c4385865022536a706f9b13f61a3 Mon Sep 17 00:00:00 2001 From: Mauro Ezequiel Moltrasio Date: Mon, 4 May 2026 10:46:08 +0200 Subject: [PATCH 2/3] trigger license check for testing --- .github/workflows/license-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/license-checks.yml b/.github/workflows/license-checks.yml index aefe6a98..34bc30db 100644 --- a/.github/workflows/license-checks.yml +++ b/.github/workflows/license-checks.yml @@ -28,7 +28,7 @@ jobs: name: Check licenses needs: - licenses-need-reevaluation - if: needs.licenses-need-reevaluation.outputs.need-reevaluation == 'true' + #if: needs.licenses-need-reevaluation.outputs.need-reevaluation == 'true' runs-on: 'ubuntu-24.04' steps: From 086a6e0aa4a66e8a1f1d98f81af827fdab68cf78 Mon Sep 17 00:00:00 2001 From: Mauro Ezequiel Moltrasio Date: Mon, 4 May 2026 10:53:38 +0200 Subject: [PATCH 3/3] Revert "trigger license check for testing" This reverts commit e9f20b69d815c4385865022536a706f9b13f61a3. --- .github/workflows/license-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/license-checks.yml b/.github/workflows/license-checks.yml index 34bc30db..aefe6a98 100644 --- a/.github/workflows/license-checks.yml +++ b/.github/workflows/license-checks.yml @@ -28,7 +28,7 @@ jobs: name: Check licenses needs: - licenses-need-reevaluation - #if: needs.licenses-need-reevaluation.outputs.need-reevaluation == 'true' + if: needs.licenses-need-reevaluation.outputs.need-reevaluation == 'true' runs-on: 'ubuntu-24.04' steps: