From 4a5626e189c5855dc1d237b3ffd1cd97240aba35 Mon Sep 17 00:00:00 2001 From: Moritz Clasmeier Date: Wed, 13 May 2026 17:52:26 +0200 Subject: [PATCH 1/2] Don't fail for main image tags containing commit IDs --- internal/stackroxversions/constraints.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/stackroxversions/constraints.go b/internal/stackroxversions/constraints.go index a70909d..6d9eca0 100644 --- a/internal/stackroxversions/constraints.go +++ b/internal/stackroxversions/constraints.go @@ -2,6 +2,7 @@ package stackroxversions import ( "fmt" + "strings" "github.com/Masterminds/semver/v3" ) @@ -19,6 +20,8 @@ var ( // SupportsAdditionalPrinterColumns checks if the provided main image tag supports // the additional printer columns (i.e., >= 4.9.0). func SupportsAdditionalPrinterColumns(version string) (bool, error) { + // We also need to support versions such as 4.11.0-937-gf0da38f1a. + version, _, _ = strings.Cut(version, "-") semVer, err := semver.NewVersion(version) if err != nil { return false, fmt.Errorf("failed to parse operator tag %q as semantic version: %w", version, err) From 70934f7ffbe403007c342946e5ebf246b1d446fd Mon Sep 17 00:00:00 2001 From: Moritz Clasmeier Date: Wed, 13 May 2026 17:54:31 +0200 Subject: [PATCH 2/2] Make --early-readiness=true the default --- internal/deployer/config.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/internal/deployer/config.go b/internal/deployer/config.go index 1a6b2ca..907fc4b 100644 --- a/internal/deployer/config.go +++ b/internal/deployer/config.go @@ -92,8 +92,9 @@ type CentralConfig struct { // DefaultCentralConfig returns a CentralConfig with sensible defaults. func DefaultCentralConfig() CentralConfig { return CentralConfig{ - DeployTimeout: DefaultCentralWaitTimeout, - Namespace: "acs-central", + DeployTimeout: DefaultCentralWaitTimeout, + Namespace: "acs-central", + EarlyReadiness: true, Spec: map[string]interface{}{ "central": map[string]interface{}{ "telemetry": map[string]interface{}{ @@ -209,9 +210,10 @@ type SecuredClusterConfig struct { // DefaultSecuredClusterConfig returns a SecuredClusterConfig with sensible defaults. func DefaultSecuredClusterConfig() SecuredClusterConfig { return SecuredClusterConfig{ - DeployTimeout: DefaultSecuredClusterWaitTimeout, - Namespace: "acs-sensor", - Spec: make(map[string]interface{}), + DeployTimeout: DefaultSecuredClusterWaitTimeout, + Namespace: "acs-sensor", + EarlyReadiness: true, + Spec: make(map[string]interface{}), } }