Skip to content

ROX-25690: Use versioned offline defs in offline bundles #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jvdm merged 1 commit into from
Oct 11, 2024
Merged

ROX-25690: Use versioned offline defs in offline bundles #1643

jvdm merged 1 commit into from
Oct 11, 2024

Conversation

@jvdm
Copy link
Contributor

@jvdm jvdm commented Sep 13, 2024 •
edited
Loading

Description

Update the offline bundle workflow to use versioned offline definitions (create based on https://github.com/stackrox/stackrox/pull/12516/files) instead of release-based defintions. Also, from 4.6.x onward, versioned offline bundles are published by Z-stream.

Test

See tests performed at stackrox/stackrox#12895

@jvdm jvdm requested a review from a team September 13, 2024 01:18
dcaravel
dcaravel reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@dcaravel dcaravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review:

@jvdm jvdm mentioned this pull request Sep 18, 2024
Merged
9 tasks
@jvdm jvdm force-pushed the jvdm/versioned-vulns-offline branch from a8290fc to 92a330e Compare September 20, 2024 22:15
@jvdm
Copy link
Contributor Author

jvdm commented Sep 20, 2024

Preliminary review:

Could you please send me the full review? I am OK waiting a bit for a full review, in case you're holding the remainder waiting for my replies on this preliminary.

@jvdm jvdm requested a review from dcaravel September 20, 2024 22:19
@dcaravel
Copy link
Contributor

dcaravel commented Sep 20, 2024

Could you please send me the full review? I am OK waiting a bit for a full review, in case you're holding the remainder waiting for my replies on this preliminary.

Called it preliminary due to not being tested yet:

image

@RTann
Copy link
Contributor

RTann commented Sep 24, 2024

In progress, waiting on https://github.com/stackrox/stackrox/pull/12516/files for full end-to-end testing.

Should we wait for that PR to be merged and for you to do your testing before reviewing this?

@RTann
Copy link
Contributor

RTann commented Sep 24, 2024

In progress, waiting on https://github.com/stackrox/stackrox/pull/12516/files for full end-to-end testing.

Should we wait for that PR to be merged and for you to do your testing before reviewing this?

I see this was already asked, and it seems like you still want a review, so I'll look

@RTann RTann closed this Sep 24, 2024
@RTann RTann reopened this Sep 24, 2024
@RTann
Copy link
Contributor

RTann commented Sep 24, 2024

Sorry I pressed the wrong button when submitting my comment 😬

RTann
RTann reviewed Sep 24, 2024
View reviewed changes
@jvdm jvdm requested a review from RTann September 25, 2024 23:32
RTann
RTann reviewed Sep 25, 2024
View reviewed changes
@jvdm jvdm force-pushed the jvdm/versioned-vulns-offline branch from 92a330e to 3c79493 Compare September 29, 2024 03:10
@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2024 •
edited
Loading

@jvdm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/scale-tests 92a330e link false /test scale-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

RTann
RTann reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of this PR says it's still untested. Is that still true?

@jvdm jvdm mentioned this pull request Oct 1, 2024
Merged
9 tasks
@jvdm jvdm force-pushed the jvdm/versioned-vulns-offline branch from 3c79493 to 0ad650d Compare October 2, 2024 23:25
@jvdm jvdm added the generate-dumps-on-pr Generates the image based on dumps from the PR label Oct 4, 2024
@jvdm jvdm force-pushed the jvdm/versioned-vulns-offline branch from 0ad650d to 19f719d Compare October 4, 2024 05:53
@jvdm jvdm force-pushed the jvdm/versioned-vulns-offline branch from 19f719d to bc22715 Compare October 4, 2024 21:23
@jvdm jvdm mentioned this pull request Oct 6, 2024
Merged
5 tasks
@jvdm jvdm changed the title feat: Use versioned offline defs in offline bundles ROX-25690: Use versioned offline defs in offline bundles Oct 7, 2024
@jvdm
Copy link
Contributor Author

jvdm commented Oct 7, 2024

The description of this PR says it's still untested. Is that still true?

No, tests were made on dev builds for 4.6.x, see description.

@jvdm jvdm requested a review from RTann October 7, 2024 17:59
RTann
RTann approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but hard to know for certain until we start making 4.6 and see how this goes

@jvdm jvdm merged commit af2eb7b into master Oct 11, 2024
@jvdm jvdm deleted the jvdm/versioned-vulns-offline branch October 11, 2024 19:17
@RTann RTann mentioned this pull request Oct 11, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BradLugo BradLugo Awaiting requested review from BradLugo

@daynewlee daynewlee Awaiting requested review from daynewlee

@dcaravel dcaravel Awaiting requested review from dcaravel

1 more reviewer

@RTann RTann RTann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

generate-dumps-on-pr Generates the image based on dumps from the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvdm @dcaravel @RTann