Skip to content

Conversation

@RTann
Copy link
Contributor

@RTann RTann commented Oct 11, 2024

Description

I was looking at the logs, and, unfortunately, gsutil doesn't log what it's copying very well... So, I add logs here. I also did two other super tiny changes while I'm here

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

no

How I validated my change

CI

@RTann RTann added the pr-update-scanner-vulns Update Scanner's vulnerability data for this PR label Oct 11, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@RTann RTann marked this pull request as ready for review October 11, 2024 19:38
@RTann RTann requested a review from a team as a code owner October 11, 2024 19:38
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 11, 2024

Images are ready for the commit at 4016df9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-719-g4016df955b.

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 475e699.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-710-g475e69983f.

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.14%. Comparing base (6d36261) to head (4016df9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12992      +/-   ##
==========================================
- Coverage   48.14%   48.14%   -0.01%     
==========================================
  Files        2448     2448              
  Lines      176123   176123              
==========================================
- Hits        84794    84790       -4     
- Misses      84503    84505       +2     
- Partials     6826     6828       +2     
Flag Coverage Δ
go-unit-tests 48.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RTann RTann force-pushed the ross-minor-workflow-update-101124 branch from 475e699 to eccb7da Compare October 11, 2024 23:18
@RTann RTann requested a review from jvdm October 11, 2024 23:19
@RTann RTann force-pushed the ross-minor-workflow-update-101124 branch from eccb7da to 4016df9 Compare October 14, 2024 19:47
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2024

@RTann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-17-nongroovy-e2e-tests 4016df9 link false /test ocp-4-17-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RTann RTann merged commit b32aa35 into master Oct 15, 2024
@RTann RTann deleted the ross-minor-workflow-update-101124 branch October 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci pr-update-scanner-vulns Update Scanner's vulnerability data for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants