-
Notifications
You must be signed in to change notification settings - Fork 168
ROX-29043: ARM64 unittests #15140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rc-arm-local
Are you sure you want to change the base?
ROX-29043: ARM64 unittests #15140
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at db84698. To use with deploy scripts, first |
|
Images are ready for the commit at d3183fd. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rc-arm-local #15140 +/- ##
================================================
+ Coverage 49.46% 49.49% +0.02%
================================================
Files 2691 2691
Lines 197901 197901
================================================
+ Hits 97894 97944 +50
+ Misses 92363 92317 -46
+ Partials 7644 7640 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
466be80 to
1492e90
Compare
3cc8763 to
5182fdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @robbycochran - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
5182fdf to
1c821c3
Compare
0337247 to
0750481
Compare
478da05 to
dbca462
Compare
0750481 to
3833d04
Compare
f0774bf to
323324a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The ui job defines a matrix but no longer has a runs-on value, which will make the workflow invalid; you probably want a runs-on line similar to the other jobs, e.g., using the matrix.arch-based ubuntu-24.04/ubuntu-24.04-arm selection.
- The arch matrix and ubuntu-24.04${{ (matrix.arch == 'arm64' && '-arm') || '' }} runs-on expression are duplicated across jobs; consider extracting this into a reusable workflow or a consistent pattern to reduce duplication and the risk of divergence between jobs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The ui job defines a matrix but no longer has a runs-on value, which will make the workflow invalid; you probably want a runs-on line similar to the other jobs, e.g., using the matrix.arch-based ubuntu-24.04/ubuntu-24.04-arm selection.
- The arch matrix and ubuntu-24.04${{ (matrix.arch == 'arm64' && '-arm') || '' }} runs-on expression are duplicated across jobs; consider extracting this into a reusable workflow or a consistent pattern to reduce duplication and the risk of divergence between jobs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
66b097d to
bf64efd
Compare
795ddf9185 Add arm64 runner to go unit-tests 18d13aaa7a update 1a77441558 runner 21fc418719 combine 8eff5ea9db update proto a1f9b03af8 skip junit2jira on arm64
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
bf64efd to
e14bb85
Compare
Description
Uses arm64 test image: stackrox/rox-ci-image#225 and arm64 Github actions to run stackrox unit tests on arm64 architecture. I don't expect any issues with golang across architectures, but this is an easy validation.
arm64 unit tests are slightly faster (36m vs 44m).
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!