Skip to content

Conversation

@robbycochran
Copy link
Contributor

@robbycochran robbycochran commented May 1, 2025

Description

Uses arm64 test image: stackrox/rox-ci-image#225 and arm64 Github actions to run stackrox unit tests on arm64 architecture. I don't expect any issues with golang across architectures, but this is an easy validation.

arm64 unit tests are slightly faster (36m vs 44m).

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented May 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@robbycochran robbycochran changed the title (feat): run go unit tests on arm64 feat(arm64): run go unit tests on arm64 May 1, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 1, 2025

Images are ready for the commit at db84698.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-436-gdb84698537.

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at d3183fd.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-600-g529a34fda6.

@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.49%. Comparing base (a14169e) to head (db84698).

Additional details and impacted files
@@               Coverage Diff                @@
##           rc-arm-local   #15140      +/-   ##
================================================
+ Coverage         49.46%   49.49%   +0.02%     
================================================
  Files              2691     2691              
  Lines            197901   197901              
================================================
+ Hits              97894    97944      +50     
+ Misses            92363    92317      -46     
+ Partials           7644     7640       -4     
Flag Coverage Δ
go-unit-tests 49.49% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robbycochran robbycochran changed the title feat(arm64): run go unit tests on arm64 ROX-29043: run go unit tests on arm64 May 28, 2025
@robbycochran robbycochran marked this pull request as ready for review May 28, 2025 18:24
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robbycochran - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@robbycochran robbycochran requested a review from a team as a code owner May 30, 2025 22:17
@robbycochran robbycochran requested review from porridge and removed request for a team May 30, 2025 22:17
@robbycochran robbycochran changed the title ROX-29043: run go unit tests on arm64 ROX-29043: ARM64 unittests May 30, 2025
@robbycochran robbycochran changed the base branch from master to rc-arm-local May 30, 2025 22:18
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The ui job defines a matrix but no longer has a runs-on value, which will make the workflow invalid; you probably want a runs-on line similar to the other jobs, e.g., using the matrix.arch-based ubuntu-24.04/ubuntu-24.04-arm selection.
  • The arch matrix and ubuntu-24.04${{ (matrix.arch == 'arm64' && '-arm') || '' }} runs-on expression are duplicated across jobs; consider extracting this into a reusable workflow or a consistent pattern to reduce duplication and the risk of divergence between jobs.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The ui job defines a matrix but no longer has a runs-on value, which will make the workflow invalid; you probably want a runs-on line similar to the other jobs, e.g., using the matrix.arch-based ubuntu-24.04/ubuntu-24.04-arm selection.
- The arch matrix and ubuntu-24.04${{ (matrix.arch == 'arm64' && '-arm') || '' }} runs-on expression are duplicated across jobs; consider extracting this into a reusable workflow or a consistent pattern to reduce duplication and the risk of divergence between jobs.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

robbycochran and others added 7 commits November 25, 2025 10:53
795ddf9185 Add arm64 runner to go unit-tests
18d13aaa7a update
1a77441558 runner
21fc418719 combine
8eff5ea9db update proto
a1f9b03af8 skip junit2jira on arm64
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants