New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-10845: Refactor notifier scrubbing #1803
Conversation
|
Skipping CI for Draft Pull Request. |
|
Tag for build #608969 is export MAIN_IMAGE_TAG='3.70.x-239-gcbf11648fc'
|
|
/test gke-qa-e2e-tests |
b397396
to
ba39331
Compare
ba39331
to
cbf1164
Compare
|
@mtodor: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for doing this!
Only suggestion is to update the PR title (and, therefore, commit message) to be more specific about the change being done (something like "Move notifier scrubbing to datastore layer") rather than just saying "refactor".
|
/test style-checks |
Description
We have moved logic for scrubbing of notifiers to the datastore and introduced pair interface functions with and without scrubbing.
NOTE: for more information, please check the related ticket.
Checklist
[ ] Evaluated and added CHANGELOG entry if required- not relevant[ ] Determined and documented upgrade steps- not relevant[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)- not relevantTesting Performed
admintestPagerDuty notifiercurlcommand to get data over REST APIcurlcommand to get data over GraphQL