Skip to content
This repository was archived by the owner on Mar 12, 2020. It is now read-only.

Conversation

@zone117x
Copy link
Contributor

@zone117x zone117x commented Nov 5, 2019

Closes leather-io/extension#16

Remove dependency on the Node.js crypto module/polyfill -- replace with native Web Crypto operations in blockstack.js.

Also removed the bip32 dependency since it is already a (re-exported) dependency of bitcoinjs-lib. This prevents any future versioning issues between the two.

There are a few relatively expensive cryptographic operations that are performed by internal bip39 and bitcoinjs-lib code -- namely secp256k1 EC ops and sha256/512 hashing. Ideally, these don't account for much of the computational time, since refactoring these are difficult.

* feature/auth-response:
  fixing exports
  use tsdx for building
  change name to @blockstack/keychain
@zone117x zone117x requested a review from hstove November 5, 2019 23:08
@zone117x zone117x mentioned this pull request Nov 6, 2019
8 tasks
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super late review - sorry! Great work.

@hstove hstove merged commit 7fc29d8 into feature/auth-response Nov 26, 2019
@stackatron stackatron removed this from the DevX 2020 Q1 - Sprint 2 milestone Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants