New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain why the typescript dependency? #294
Comments
Hi @zachlysobey The blockstack.js lib is written in typescript. We recently did an overhaul of that package to determine the minimum required set of packages. |
@moxiegirl sounds like it is there for a reason then? But I'm still confused. I see that |
Hi @zachlysobey You're right; nothing's written in typescript in Animal Kingdom and it's not needed. I just put it in there because a lot of folks in Animal Kingdom are new users and we don't want to confuse them with a lot of peer dependency warnings, in case someone doesn't know they can be ignored (having typescript in there clears about a half-dozen). |
@zachlysobey Thank you for this issue. I'm going to go ahead and change the title slightly. I'll add a small explanation to the docs about why we do this. |
zachlysobey commentedJun 21, 2019
This is a nitpick for sure, but I think there is a superfluous
typescript
dependency?There doesn't seem to be any
.ts
files in the project, no other reference totypescript
.If this was added in error, probably makes sense to do:
That should get rid of
package.json
ANDpackage-lock.json
references.The text was updated successfully, but these errors were encountered: