Stacktrace support in Chromium #30

Merged
merged 2 commits into from Nov 1, 2011

Conversation

2 participants
@Miroff

Miroff commented Oct 30, 2011

There was two issues:

  1. 56c407e Stacktrace items like "http://example.com/foo.js:51/3" wasn't parsed preperly. I've splitted regular expressions to parse URL and lineno/charno separately.
  2. ae6843a Chromium doesn't support setting User-Agent in request. It print "Refused to set unsafe header "User-Agent"" warning instead. This feature seem useless, so I just removed this code.

eriwen added a commit that referenced this pull request Nov 1, 2011

Merge pull request #30 from Miroff/master
Stacktrace support in Chromium

@eriwen eriwen merged commit d17d9ae into stacktracejs:master Nov 1, 2011

@eriwen

This comment has been minimized.

Show comment Hide comment
@eriwen

eriwen Nov 1, 2011

Owner

Tests pass, code looks good.

Thank you!

Owner

eriwen commented Nov 1, 2011

Tests pass, code looks good.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment