From 34367b6fe0b79acbabfd72c517adacecb719db39 Mon Sep 17 00:00:00 2001 From: Yaroslav Yakovlev Date: Thu, 16 Jan 2014 12:03:13 +0100 Subject: [PATCH 1/3] removed unneeded "else" statements As every if have return statement else are not needed --- stacktrace.js | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/stacktrace.js b/stacktrace.js index 5c080bc..961232c 100644 --- a/stacktrace.js +++ b/stacktrace.js @@ -68,13 +68,21 @@ mode: function(e) { if (e['arguments'] && e.stack) { return 'chrome'; - } else if (e.stack && e.sourceURL) { + } + + if (e.stack && e.sourceURL) { return 'safari'; - } else if (e.stack && e.number) { + } + + if (e.stack && e.number) { return 'ie'; - } else if (e.stack && e.fileName) { + } + + if (e.stack && e.fileName) { return 'firefox'; - } else if (e.message && e['opera#sourceloc']) { + } + + if (e.message && e['opera#sourceloc']) { // e.message.indexOf("Backtrace:") > -1 -> opera9 // 'opera#sourceloc' in e -> opera9, opera10a // !e.stacktrace -> opera9 @@ -86,18 +94,23 @@ return 'opera9'; // use e.message } return 'opera10a'; // use e.stacktrace - } else if (e.message && e.stack && e.stacktrace) { + } + + if (e.message && e.stack && e.stacktrace) { // e.stacktrace && e.stack -> opera10b if (e.stacktrace.indexOf("called from line") < 0) { return 'opera10b'; // use e.stacktrace, format differs from 'opera10a' } // e.stacktrace && e.stack -> opera11 return 'opera11'; // use e.stacktrace, format differs from 'opera10a', 'opera10b' - } else if (e.stack && !e.fileName) { + } + + if (e.stack && !e.fileName) { // Chrome 27 does not have e.arguments as earlier versions, // but still does not have e.fileName as Firefox return 'chrome'; } + return 'other'; }, From e76a10fb416115a71c0fc75eaeba57626348d347 Mon Sep 17 00:00:00 2001 From: Yaroslav Yakovlev Date: Sun, 26 Jan 2014 05:30:07 +0800 Subject: [PATCH 2/3] removed the trailing spaces in mode function --- stacktrace.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/stacktrace.js b/stacktrace.js index 961232c..dfe7bf4 100644 --- a/stacktrace.js +++ b/stacktrace.js @@ -68,19 +68,19 @@ mode: function(e) { if (e['arguments'] && e.stack) { return 'chrome'; - } + } if (e.stack && e.sourceURL) { return 'safari'; - } + } if (e.stack && e.number) { return 'ie'; - } + } if (e.stack && e.fileName) { return 'firefox'; - } + } if (e.message && e['opera#sourceloc']) { // e.message.indexOf("Backtrace:") > -1 -> opera9 @@ -94,7 +94,7 @@ return 'opera9'; // use e.message } return 'opera10a'; // use e.stacktrace - } + } if (e.message && e.stack && e.stacktrace) { // e.stacktrace && e.stack -> opera10b @@ -103,7 +103,7 @@ } // e.stacktrace && e.stack -> opera11 return 'opera11'; // use e.stacktrace, format differs from 'opera10a', 'opera10b' - } + } if (e.stack && !e.fileName) { // Chrome 27 does not have e.arguments as earlier versions, From f64010f9bdd062d5ee6f46ef54066d7cfa41f9e3 Mon Sep 17 00:00:00 2001 From: Yaroslav Yakovlev Date: Mon, 27 Jan 2014 02:07:33 +0800 Subject: [PATCH 3/3] removed trailing spaces in the empty lines in mode function. --- stacktrace.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/stacktrace.js b/stacktrace.js index dfe7bf4..e8c0e5c 100644 --- a/stacktrace.js +++ b/stacktrace.js @@ -69,19 +69,19 @@ if (e['arguments'] && e.stack) { return 'chrome'; } - + if (e.stack && e.sourceURL) { return 'safari'; } - + if (e.stack && e.number) { return 'ie'; } - + if (e.stack && e.fileName) { return 'firefox'; } - + if (e.message && e['opera#sourceloc']) { // e.message.indexOf("Backtrace:") > -1 -> opera9 // 'opera#sourceloc' in e -> opera9, opera10a @@ -95,7 +95,7 @@ } return 'opera10a'; // use e.stacktrace } - + if (e.message && e.stack && e.stacktrace) { // e.stacktrace && e.stack -> opera10b if (e.stacktrace.indexOf("called from line") < 0) { @@ -104,13 +104,13 @@ // e.stacktrace && e.stack -> opera11 return 'opera11'; // use e.stacktrace, format differs from 'opera10a', 'opera10b' } - + if (e.stack && !e.fileName) { // Chrome 27 does not have e.arguments as earlier versions, // but still does not have e.fileName as Firefox return 'chrome'; } - + return 'other'; },