New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate messages on a team kill detection #4

Closed
stajs opened this Issue Sep 27, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@stajs
Copy link
Owner

stajs commented Sep 27, 2014

Currently, on a team kill, the killer will get a message for:

  1. The Team kill.
  2. Either the Kick countdown or Kick imminent.

... and the victim will get a message for:

  1. The Team kill.
  2. Either the Kick countdown or Kick imminent.
  3. Optionally the killer/victim stats.
  4. The Victim prompt.

Consider consolidating all the placeholders to a single message each for Killer message and Victim message.

stajs added a commit that referenced this issue Sep 29, 2014

@stajs stajs closed this in fcc7615 Sep 30, 2014

@stajs

This comment has been minimized.

Copy link
Owner Author

stajs commented Sep 30, 2014

Setting for Show victim stats? is now redundant so should be taken out.

@stajs stajs reopened this Sep 30, 2014

stajs added a commit that referenced this issue Sep 30, 2014

@stajs stajs closed this in 7c7a1f6 Sep 30, 2014

@stajs

This comment has been minimized.

Copy link
Owner Author

stajs commented Sep 30, 2014

Saving messages is not right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment