diff --git a/CHANGELOG.md b/CHANGELOG.md index 6576491d..c9abb85d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,9 @@ All notable changes to this project will be documented here. +### v2.1.19 +- Fix: Reverts [PR-240](https://github.com/stakater/application/pull/240), It can already be configured via `paths` [PR-247](https://github.com/stakater/application/pull/247) + ### v2.1.18 - feat: Add vertical pod autoscaler template [PR-249](https://github.com/stakater/application/pull/249) @@ -24,7 +27,7 @@ All notable changes to this project will be documented here. - Fix: make deployment.image.tag and job.image.tag optional [PR-234](https://github.com/stakater/application/pull/234) ### v2.1.12 -- Caused by Change Log update +- Update: Changelog updates. This release shouldnt have been made as the head commit had [`[skip ci]`](https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs). [PR-248](https://github.com/stakater/application/pull/248) ### v2.1.11 - Feature: Add topologySpreadConstraints [PR-239](https://github.com/stakater/application/pull/239) diff --git a/Tiltfile b/Tiltfile index b85ffcd1..330dfc28 100644 --- a/Tiltfile +++ b/Tiltfile @@ -51,7 +51,7 @@ vpa_namespace = "openshift-vertical-pod-autoscaler" namespace_create(vpa_namespace) local_resource( 'openshift-vertical-pod-autoscaler', - cmd='helm install openshift-vertical-pod-autoscaler -n openshift-vertical-pod-autoscaler oci://ghcr.io/stakater/charts/openshift-vertical-pod-autoscaler' + cmd='helm install openshift-vertical-pod-autoscaler -n openshift-vertical-pod-autoscaler oci://ghcr.io/stakater/charts/openshift-vertical-pod-autoscaler --version=0.0.3' ) # Wait until VPA CRD becomes available diff --git a/application/templates/ingress.yaml b/application/templates/ingress.yaml index 728af3c1..760439f1 100644 --- a/application/templates/ingress.yaml +++ b/application/templates/ingress.yaml @@ -36,13 +36,7 @@ spec: name: {{ default "http" (.servicePort) }} {{- end }} {{- else }} - - path: "/" - pathType: "ImplementationSpecific" - backend: - service: - name: {{ $applicationNameTpl }} - port: - name: {{ default "http" (.servicePort) }} + {{ fail "Specify paths for ingress host, check values.yaml" }} {{- end }} {{- end -}} {{- if .Values.ingress.tls }} diff --git a/application/values-test.yaml b/application/values-test.yaml index 2f2affb9..3769cb7e 100644 --- a/application/values-test.yaml +++ b/application/values-test.yaml @@ -280,8 +280,7 @@ ingress: # List of host addresses to be exposed by this Ingress hosts: - - host: chart-example-1.local - - host: chart-example-2.local + - host: chart-example.local paths: - path: / # pathType: '' diff --git a/application/values.yaml b/application/values.yaml index e816371f..00c40bc0 100644 --- a/application/values.yaml +++ b/application/values.yaml @@ -358,8 +358,8 @@ ingress: # List of host addresses to be exposed by this Ingress hosts: - host: chart-example.local - # paths: - # - path: / + paths: + - path: / # pathType: '' # serviceName: '' # servicePort: ''