From 563ea393da0a6ed6124f52a9ecef4cfaf6a4b90b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Marques?= Date: Fri, 12 Jan 2024 11:11:31 +0000 Subject: [PATCH 1/3] fix clusterIP null field --- application/templates/service.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/application/templates/service.yaml b/application/templates/service.yaml index 2286377d..9115b5a4 100644 --- a/application/templates/service.yaml +++ b/application/templates/service.yaml @@ -16,7 +16,9 @@ metadata: {{- end }} spec: type: {{ .Values.service.type }} +{{- with .Values.service.clusterIP }} clusterIP: {{ .Values.service.clusterIP }} +{{- end }} {{- if eq .Values.service.type "LoadBalancer" }} {{- with .Values.service.loadBalancerIP }} loadBalancerIP: {{ . }} From c6bcec72c93d8ce3841bac768a833b3048b44552 Mon Sep 17 00:00:00 2001 From: Zadkiel Aharonian Date: Fri, 12 Jan 2024 19:00:04 +0100 Subject: [PATCH 2/3] fix with context --- application/templates/service.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/application/templates/service.yaml b/application/templates/service.yaml index 9115b5a4..cba72c8b 100644 --- a/application/templates/service.yaml +++ b/application/templates/service.yaml @@ -17,7 +17,7 @@ metadata: spec: type: {{ .Values.service.type }} {{- with .Values.service.clusterIP }} - clusterIP: {{ .Values.service.clusterIP }} + clusterIP: {{ . }} {{- end }} {{- if eq .Values.service.type "LoadBalancer" }} {{- with .Values.service.loadBalancerIP }} From 4ec72c64f6f3bb6d004ce30fe008290367afb50b Mon Sep 17 00:00:00 2001 From: Zadkiel Aharonian Date: Fri, 12 Jan 2024 19:01:25 +0100 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e9d2cf91..d946511e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,9 @@ All notable changes to this project will be documented here. +### v2.3.2 +- Feature: fix clusterIP null field introduced by [PR-275](https://github.com/stakater/application/pull/275) [PR-295](https://github.com/stakater/application/pull/295) + ### v2.3.1 - Feature: Allow loadbalancer service external IP [PR-275](https://github.com/stakater/application/pull/275) - Feature: Allowing HPA behavior to be set [PR-292](https://github.com/stakater/application/pull/292)