One map responsive #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrelsford
approved these changes
May 19, 2022
|
@ebrelsford yea I think that's a great idea. I'll open an issue for that on merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65
Closes #66
This allows a single map pane as well as creates a responsive mode. For now, responsive mode only works when looking at just one map to be able to get something out more quickly. There may be some complications in allowing this for 2 maps considering the size is so variable, so I'm inclined to handle that as a followup. Let me know if you disagree here though! Width and height are persisted in the URL.
@ebrelsford I've run into a bug where very occasionally the
mapsarray in the URL will reset to blank and I'll see zero maps. This isn't something I can consistently replicate and it's possible it's a preexisting bug to this PR. I'm not sure what is causing this and I can't think of any code here that would have that effect. Please let me know if you run into this and have any hunches.