Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of save_diagnostics for sampler #182

Merged
merged 9 commits into from Dec 5, 2019

Conversation

@wesbarnett
Copy link
Collaborator

wesbarnett commented Nov 26, 2019

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Adds an option to sampler, 'optimize', and 'variational' methods for outputting diagnostic files.

Fixes #158.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): American Express

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@wesbarnett wesbarnett force-pushed the wesbarnett:feature/save_diagnostics branch from c021cd8 to 7523530 Dec 2, 2019
@wesbarnett wesbarnett force-pushed the wesbarnett:feature/save_diagnostics branch from dbed236 to ea5dc2f Dec 2, 2019
@wesbarnett wesbarnett requested review from mitzimorris and ahartikainen Dec 4, 2019
Copy link
Contributor

ahartikainen left a comment

LGTM

(minor comment on style)

@@ -42,6 +42,7 @@ def __init__(
'found {}'.format(chains)
)
self._csv_files = []
self._diagnostic_files = [None for i in range(chains)]

This comment has been minimized.

Copy link
@ahartikainen

ahartikainen Dec 4, 2019

Contributor

Maybe use _ if i is not used

[None for _ in range(chains)]
Copy link
Member

mitzimorris left a comment

LGTM!
agree with Ari's comment above - please fix.

@wesbarnett wesbarnett force-pushed the wesbarnett:feature/save_diagnostics branch from ca11290 to f2bd1e1 Dec 5, 2019
@wesbarnett

This comment has been minimized.

Copy link
Collaborator Author

wesbarnett commented Dec 5, 2019

Okay, made the style fix. Also merged in master again.

@wesbarnett wesbarnett merged commit f20c9bb into stan-dev:master Dec 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.