Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/issue 1213 Trimming boost #1223
The main objective of this PR is to trim the Boost library folder in
This PR also adds the
It also edits the
I manually commented out the
I dont think there is a better way than to go through the 5 commits that are actually readable/reviewable. The other 3 commits are done by the script so they can be reviewed that way.
The commits and the description of the changes:
03a88d7 adds the -u flag to the upgrade sundials script (explained above in the PR post).
14312e2 this one adds the upgrade boost file and will be the largest change to review. Its mostly a copy of the sundials one with the cleanup at the end.
c391f42 chmod changes on the upgrade-boost.sh
b5f502a I went and manually commented out the deprecated header warning in the boost/random. In 1.0.70 this is no longer needed so I decided not to include this in the script but rather add it manually.
Regarding the testing failure:
Awesome. I didn't even realize that would be a problem.
Great. I just looked through that and it looks clean enough for someone else to pick up.
That's great! I think that's a perfectly good use case.
What's happening here? Do we have a lot of warnings? Do we include the deprecated header directly? Is this a current problem on
We dont have any warnings on develop because this was already commented out on the PR that upgraded to 1.69.0 (see last commit in #1082). Its not included directly but through including boost/random and has been fixed for 1.70.0 (boostorg/random#49).
So the issue is that
Probably that line in the gitignore is too broad and should be narrowed to just the temporary build files.…
On Thu, May 9, 2019 at 15:51 Rok Češnovar ***@***.***> wrote: So the issue is that lib/boost_*/tools/build/ is in .gitignore, but the tests need these files <http://d1m1s1b1.stat.columbia.edu:8080/blue/organizations/jenkins/Math%20Pipeline/detail/PR-1223/4/pipeline/24> : cd lib/boost_1.69.0; ./bootstrap.sh ./bootstrap.sh: 1: ./bootstrap.sh: ./tools/build/src/engine/build.sh: not found Building Boost.Build engine with toolset ... Failed to build Boost.Build build engine I am not sure how, but @wds15 <https://github.com/wds15> got this directory through in the last Boost upgrade, but you can see that they were facing the same issue in that PR #1082 (comment) <#1082 (comment)> I am also tagging @seantalts <https://github.com/seantalts> since he added those lines to .gitignore (4fbb427 #diff-a084b794bc0759e7a6b77810e01874f2 <4fbb427#diff-a084b794bc0759e7a6b77810e01874f2> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1223 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGET3E4EUIHVF6TTX7AUUDPUR6CTANCNFSM4HKWQLQA> .