Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: remove unused LIBSUNDIALS #2885

Merged
merged 1 commit into from
Mar 24, 2023
Merged

make: remove unused LIBSUNDIALS #2885

merged 1 commit into from
Mar 24, 2023

Conversation

WardBrian
Copy link
Member

Summary

Following stan-dev/cmdstan#1151, all our makefiles now use SUNDIALS_TARGET instead of LIBSUNDIALS.

This completes the checklist @syclik made here: #2861 (comment)

Checklist

  • Math issue #(issue number)

  • Copyright holder: (fill in copyright holder information)

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian WardBrian merged commit f6cb7da into develop Mar 24, 2023
@WardBrian WardBrian deleted the cleanup/libsundials branch March 24, 2023 21:49
@WardBrian WardBrian mentioned this pull request Jun 16, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants