Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Replacing const char* arguments with std::string in error functions #584
Cleaning up code by replacing uses of
This shouldn't affect the behavior of the code.
Make our code base more idiomatic C++ and more consistent.
How to Verify:
Check the diff. Most of it is going to be very repetitive.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:
Looks good minus the typo and maybe accidental removal of a
I don't know much about the design tradeoffs between
char * and
std::string but from what I briefly read this seems like a reasonable thing to do.
@seantalts Yes, we definitely want to make this change.
I'm pretty sure all those