New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvodes broken #517

Open
ahartikainen opened this Issue Sep 12, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ahartikainen
Collaborator

ahartikainen commented Sep 12, 2018

cvodes should use the current folder structure (Sundials).

I tried to fix this by following cmakelist in cvodes folder, but I couldn't get STAN_SUNDIALS_FPRINTF to link correctly.

https://github.com/stan-dev/math/blob/develop/lib/sundials_3.1.0/src/cvodes/CMakeLists.txt

STAN_SUNDIALS_FPRINTF is defined in here: https://github.com/stan-dev/math/blob/develop/lib/sundials_3.1.0/include/stan_sundials_printf_override.hpp

Based on the quick google apparently either distutils.Extension is "broken" and it might be fixed with setuptools. Other one was that the order of included libs should come after -o python_module.so

extra_link_args going to Extension does put stuff after the .so but I still couldn't get it to link.

@riddell-stan

This comment has been minimized.

Show comment
Hide comment
@riddell-stan

riddell-stan Sep 13, 2018

Contributor

Just looking through the travis error log I spotted this:

gcc: error: /home/travis/miniconda3/envs/linux_gcc_py3/lib/python3.5/site-packages/pystan/stan/lib/stan_math/lib/cvodes_2.9.0/src/cvodes/cvodea.c: No such file or directory
gcc: fatal error: no input files

Looks like the include directory wasn't updated. I hope #518 fixes the problem.

Contributor

riddell-stan commented Sep 13, 2018

Just looking through the travis error log I spotted this:

gcc: error: /home/travis/miniconda3/envs/linux_gcc_py3/lib/python3.5/site-packages/pystan/stan/lib/stan_math/lib/cvodes_2.9.0/src/cvodes/cvodea.c: No such file or directory
gcc: fatal error: no input files

Looks like the include directory wasn't updated. I hope #518 fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment