New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce target += and deprecate increment_log_prob() statements #1800

Closed
bob-carpenter opened this Issue Mar 13, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@bob-carpenter
Contributor

bob-carpenter commented Mar 13, 2016

Summary:

Introduce statement target += ...; for adding log prob to total log density; deprecate increment_log_prob(...)

Description:

  • grammar mods to allow target += expression;
    • test
  • deprecation warning for old syntax increment_log_prob(...);
    • test
  • add target() function for current value of target accumulator
    • test it compiles
  • deprecate get_lp() function
    • test warning message
  • remove access to lp__ variable altogether
    • change warning to error
    • test
  • add target to list of reserved words
    • test
  • update manual
    • replace increment_log_prob(...) with target += ...
    • add new syntax to BNF

@bob-carpenter bob-carpenter self-assigned this Mar 13, 2016

@bob-carpenter bob-carpenter added this to the v2.9.0++ milestone Mar 13, 2016

@syclik syclik closed this in e1fb49d Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment