Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

softabs metric calling wrong Hessian functional #2321

Closed
bob-carpenter opened this issue Jun 13, 2017 · 0 comments
Closed

softabs metric calling wrong Hessian functional #2321

bob-carpenter opened this issue Jun 13, 2017 · 0 comments
Assignees
@bob-carpenter
Labels
code cleanup
Milestone
2.16.0

Comments

@bob-carpenter
Copy link
Contributor

Summary:

The softabs metric in src/stan/mcmc/hmc/hamiltonians/softabs_metric.hpp is calling the forward-mode Hessian function with stan::math::hessian<double>(softabs_fun<Model>(this->model_, 0).... It should just be calling stan::math::hessian(softabs_fun...) or it should instantiate the reverse-mode method's template parameters.

Reproducible Steps:

The problem is arising in the math lib pull request stan-dev/math#562, where the forward-mode version is split out and thus not found by the softabs_metric function.

Current Version:

v2.15.0
@bob-carpenter bob-carpenter added this to the 2.15.0++ milestone Jun 13, 2017
@bob-carpenter bob-carpenter self-assigned this Jun 13, 2017
bob-carpenter pushed a commit that referenced this issue Jun 14, 2017
Merge pull request #2323 from stan-dev/bugfix/2321-softabs-hessian-fu…
e4e4ba9 
…nctional

resolve hessian() in mcmc and model, fixes #2321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bob-carpenter bob-carpenter

Labels
code cleanup
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
1 participant
@bob-carpenter