Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Add g_ to name of g vector name in ps_point #2832

Closed
wants to merge 1 commit into from

Conversation

SteveBronder
Copy link
Collaborator

Just a quick bug fix introduced in #2828 to add std::string("g_") to the names of the ps_point method.

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Steve Bronder

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@stan-buildbot
Copy link
Contributor

(stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan, 1.01)
(stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan, 1.0)
(stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan, 1.0)
(stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan, 1.01)
(stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan, 0.99)
(stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan, 0.99)
(stat_comp_benchmarks/benchmarks/arK/arK.stan, 0.99)
(performance.compilation, 1.01)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan, 1.01)
(stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan, 0.98)
(stat_comp_benchmarks/benchmarks/sir/sir.stan, 1.1)
(stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan, 1.0)
(stat_comp_benchmarks/benchmarks/garch/garch.stan, 1.17)
(stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan, 1.02)
(stat_comp_benchmarks/benchmarks/arma/arma.stan, 1.14)
Result: 1.02870960471
Commit hash: 3fd868f

@rok-cesnovar
Copy link
Member

In order to prevent the fail on Travis, this PR needs a merge with fresh develop. Sorry for the inconvenience.

@betanalpha
Copy link
Contributor

There's no bug here.

The PR title indicates that the gradient components names are wrong, but they're fine. The code instead prepends a "q_" to the parameter names, but the parameter names don't get a prefix. Only the corresponding gradient and momenta components need a prefix to differentiate them from the parameters.

@SteveBronder
Copy link
Collaborator Author

Ahhh, oh my b. Aight cool I'll close this

@SteveBronder SteveBronder deleted the bug-fix/ps_point-names branch October 9, 2019 18:22
@serban-nicusor-toptal serban-nicusor-toptal added this to the 2.20.0++ milestone Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants