Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scala version to Scala 2.12 #28

Merged
merged 5 commits into from
May 23, 2021
Merged

Conversation

rajcspsg
Copy link
Contributor

No description provided.

@rajcspsg rajcspsg changed the title Scala 212 update scala version to Scala 2.12 May 17, 2021
@rajcspsg rajcspsg mentioned this pull request May 17, 2021
Copy link
Owner

@stanch stanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good. Just a couple of minor things.

.gitignore Outdated Show resolved Hide resolved
@@ -113,8 +113,8 @@ val site = project.in(file("site"))
file("images/tree+zipper.gif") → "images/tree+zipper.gif",
((crossTarget in demoJS).value / "demo-opt.js") → "js/demo.js"
),
SiteScaladocPlugin.scaladocSettings(config("jvm"), mappings in (Compile, packageDoc) in coreJVM, "api/jvm"),
SiteScaladocPlugin.scaladocSettings(config("js"), mappings in (Compile, packageDoc) in coreJS, "api/js"),
SiteScaladocPlugin.scaladocSettings( { val Jvm = config("jvm"); Jvm }, mappings in (Compile, packageDoc) in coreJVM, "api/jvm"),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on the this?

Copy link
Contributor Author

@rajcspsg rajcspsg May 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stanch I faced this issue sbt/librarymanagement#134 after upgrading sbt to version 1.00 from 0.13.x

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! Tricky one :)

@stanch stanch merged commit 0ac53e2 into stanch:master May 23, 2021
@stanch
Copy link
Owner

stanch commented May 23, 2021

@rajcspsg
Copy link
Contributor Author

rajcspsg commented May 24, 2021

@stanch - I created #29 to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants