Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable react-specific linting rules (pure JSX) #13

Closed
wants to merge 2 commits into from

Conversation

3 participants
@84564221
Copy link

commented Jan 6, 2016

Since JSX is intended to be used by various preprocessors (transpilers) to transform DOM tokens into standard ECMAScript and it's not a proposal to incorporate with the ECMAScript spec itself, the usage should not be restricted to only one library (react).

See standard/standard#367.

Disable react-specific JSX restrictions
- Allow unknown properties
- Disable props validation (prop-types)
@dcousens

This comment has been minimized.

Copy link
Member

commented Jan 6, 2016

NACK, though maybe @feross we should move to create eslint-config-standard-jsx for the next standard version?
I'd be happy with these changes there.

@84564221

This comment has been minimized.

Copy link
Author

commented Jan 8, 2016

Would it not be better simply to rename this repository into eslint-config-standard-jsx?

@dcousens

This comment has been minimized.

Copy link
Member

commented Jan 9, 2016

@askmatey and completely break repositories that are using this eslint config independently?

@84564221

This comment has been minimized.

Copy link
Author

commented Jan 21, 2016

The original idea of standard was to define a common, simplified coding standard. Standards are paper. I use paper to wipe my butt every day. That's how much that paper is worth. But I do not see any reason to include restrictions to a single library. React specific linting rules are bloat here.

Disable react-specific linting rules
- Do not prevent React to be incorrectly marked as unused
- Do not prevent usage of setState in componentDidUpdate

@84564221 84564221 changed the title Disable react-specific JSX restrictions Disable react-specific linting rules (pure JSX) Jan 21, 2016

@dcousens

This comment has been minimized.

Copy link
Member

commented Jan 29, 2016

@feross seems to be re-occurring issue.
Did we want to relax the rules here and just make explicit React support a user-specified eslint extension in 6?

Alternatively, we leave this as is (so existing users don't start making mistakes), and just make a new repository eslint-config-standard-jsx for 6.

@feross feross referenced this pull request Feb 5, 2016

Closed

Release proposal: standard v6 #399

25 of 25 tasks complete
@feross

This comment has been minimized.

Copy link
Member

commented Feb 6, 2016

Thanks – this is done, though not via this PR.

standard v6 will remove all opinionated react rules, opting for just some simple JSX rules. https://github.com/feross/eslint-config-standard-jsx

@feross feross closed this Feb 6, 2016

@dcousens

This comment has been minimized.

Copy link
Member

commented Feb 7, 2016

👍

@84564221

This comment has been minimized.

Copy link
Author

commented Feb 7, 2016

I told you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.