Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNew ESLint core rule: multiline-comment-style #1003
Comments
This comment has been minimized.
This comment has been minimized.
|
Here is a PR: |
This comment has been minimized.
This comment has been minimized.
uloco
commented
Oct 21, 2017
|
I think block comments should be only used as doc comments. In this way they can clearly be distinguished and syntax highlighted appropriately. Imoo we shouldn't enforce this rule... |
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
May 10, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
label
May 10, 2018
stale
bot
closed this
May 17, 2018
feross
reopened this
May 20, 2018
stale
bot
removed
the
stale
label
May 20, 2018
feross
added
the
enhancement
label
May 20, 2018
This comment has been minimized.
This comment has been minimized.
voxpelli
commented
Jul 13, 2018
|
@uloco Isn't there a difference between a doc comment and an ordinary comment in that one start with https://eslint.org/docs/rules/multiline-comment-style only mentions the need to start with I'm +1 on this and @mightyiam can probably update his PR now that ESLint 4 (and almost ESLint 5: standard/eslint-config-standard#123) is supported by |
This comment has been minimized.
This comment has been minimized.
uloco
commented
Jul 13, 2018
|
@voxpelli Yes you are right, there is a difference. It's just personal taste. I don't use block comments at all, because they look too familiar to doc comments and make problems when nesting (and toggling them). I use line comments for commenting code and doc comments for docs. It's just an opinion. If you really like to enforce this style, go for it. |
mightyiam commentedOct 15, 2017
https://eslint.org/docs/rules/multiline-comment-style
Let's set a standard for multiline comments.
The default
starred-blockseems like the way to go.