Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should automatically lint *.mjs files #1009

Closed
feross opened this issue Oct 31, 2017 · 6 comments

Comments

@feross
Copy link
Member

commented Oct 31, 2017

ES6 module support is coming to Node.js. That means a new file extension (*.mjs) that denotes an ES6 module file. standard should automatically lint this file extension, since that's what users will expect.

@yoshuawuyts

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2017

@ematipico

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2017

Yeah they've made a big of a mess

@feross

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2017

@yoshuawuyts Cool, thanks for sharing. I've just started playing around with --experimental-modules. We'll keep an eye on this!

Edit: This blog post has the most useful info I've been able to find about ESM in Node.js: http://2ality.com/2017/09/native-esm-node.html

@stale

This comment has been minimized.

Copy link

commented May 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label May 10, 2018

@stale stale bot closed this May 17, 2018

@feross feross reopened this May 20, 2018

@stale stale bot removed the stale label May 20, 2018

@feross feross added the enhancement label May 20, 2018

@feross feross added this to the standard 14 milestone Aug 13, 2019

@feross

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Only one repo started failing from this change (merge2) and it was because they had lint errors in their .mjs files and weren't manually running standard on them. So, this is a great change!

This will ship in standard 14.

@feross

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

I just remembered that .cjs files are also coming to Node, so I'll add those by default too.

feross added a commit to standard/standard-engine that referenced this issue Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.