Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest release of is-my-json-valid breaks standard #1030

Closed
tsujigiri opened this issue Dec 18, 2017 · 3 comments

Comments

@tsujigiri
Copy link

commented Dec 18, 2017

Since is-my-json-valid released version 2.17.0, I get the following error when running standard:

/home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:366
      visit(name+'['+i+']', node.items, reporter, filter, schemaPath.concat('items'))
                                                                     ^

TypeError: Cannot read property 'concat' of undefined
    at visit (/home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:366:70)
    at /home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:416:9
    at Array.forEach (<anonymous>)
    at visit (/home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:409:18)
    at /home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:543:9
    at Array.forEach (<anonymous>)
    at visit (/home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:540:31)
    at compile (/home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:565:3)
    at visit (/home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:340:16)
    at /home/helge/.node_modules/lib/node_modules/standard/node_modules/is-my-json-valid/index.js:416:9
@Kikobeats

This comment has been minimized.

Copy link

commented Dec 18, 2017

same behavior on my projects.

Looks like last is-my-json-valid version introduces a bug and is broken standard.

jameshhx referenced this issue in mafintosh/is-my-json-valid Dec 18, 2017

@LinusU

This comment has been minimized.

Copy link
Member

commented Dec 18, 2017

This was me 🙈 sorry about that!

It has been fixed upstream now, and the broken version have been deprecated on npm.

Just reinstalling or manually upgrading is-my-json-valid to 2.17.1 (npm install is-my-json-valid@2.17.1) should fix it 👌

@LinusU LinusU closed this Dec 18, 2017

@jameshhx

This comment has been minimized.

Copy link

commented Dec 18, 2017

Thanks @LinusU! 👍

@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.