Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error: couldn't resolve `eslint` babel-eslint@8.1.2 #1035

Closed
joshuaalpuerto opened this issue Dec 27, 2017 · 6 comments

Comments

@joshuaalpuerto
Copy link

commented Dec 27, 2017

Hi am not sure if this issue goes here. But when im running test on my CI its failing due to:

screen shot 2017-12-27 at 12 44 16 pm

standard@10.0.3
babel-eslint@8.1.2

I have to revert back to babel-eslint@8.0.3 to make my test pass.

Cheers!

RKushnir added a commit to ad2games/rubocop-ci that referenced this issue Dec 27, 2017

RKushnir added a commit to ad2games/rubocop-ci that referenced this issue Dec 27, 2017

@timoxley

This comment has been minimized.

Copy link
Contributor

commented Dec 30, 2017

I'm seeing a similar issue. Using babel-eslint@8.1.2 my editor (vim + ALE) reports "x is not defined" for class fields (static and instance). I get the same error running standard on the command line:

npx standard …/View3D.js
standard: Use JavaScript Standard Style (https://standardjs.com)
  …/View3D.js:6:10: 'propTypes' is not defined.
  …/View3D.js:10:3: 'viewConfig' is not defined.

Note this is a different error to not having any "standard.parser" value set in package.json.

After installing babel-eslint@8.0.3 and the issue goes away.

Something definitely up with babel-eslint@8.1.2.

@doodlewind

This comment has been minimized.

Copy link

commented Jan 6, 2018

Possible same issue raised in babel-eslint
babel/babel-eslint#564

@doodlewind

This comment has been minimized.

Copy link

commented Jan 6, 2018

I investigate a bit and found that a patch for scope analysis is introduced in #542, which is not compatible with babel-eslint@7.x. Since standard@10.x uses babel-eslint@7.x, this patch may introduce unexpected behaviors for standard@10.x.

The good news is that in standard@11.x, dependency version is updated to babel-eslint@8.x. I've tested several permutation and find two workarounds for now:

  1. Install standard@10.x with babel-eslint@7.x
  2. Install standard@11.x with babel-eslint@8.x

Any ideas fixing standard@10.x with babel-eslint@8.x, or warn user in this case?

@GBarkhatov

This comment has been minimized.

Copy link

commented Jan 6, 2018

Using babel-eslint@8.0.3 works fine, spend a day solving this.

@pex

This comment has been minimized.

Copy link

commented Jan 10, 2018

As described in babel/babel-eslint#564 (comment) this issue is not limited to standard but also to XO.

@ematipico

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2018

Thanks @pex for your comment!
Closing the issue as it's not a problem of standard but of babel-eslint@8.1.3. A temporary solution is to downgrade to babel-eslint@8.0.3

@ematipico ematipico closed this Jan 10, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
You can’t perform that action at this time.