Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard --fix shows errors, but doesn't fix them [macOS High Sierra] #1044

Closed
milankragujevic opened this issue Jan 15, 2018 · 5 comments

Comments

@milankragujevic
Copy link

commented Jan 15, 2018

Hi,

I tried running standard --fix on my Mac inside the project, and it correctly identifies the mistakes I have made in the file, meaning mixing spaces and tabs, etc... However, it doesn't actually fix anything, and on each re-run it just outputs the same problems with my code again, and does that every time.

Here is sample output:

Milans-MacBook-Air:paratii-lib milankragujevic$ standard --fix
standard: Use JavaScript Standard Style (https://standardjs.com)
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:7:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:7:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:8:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:8:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:9:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:9:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:10:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:10:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:11:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:11:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:12:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:12:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:13:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:13:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:14:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:14:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:15:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:15:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:16:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:16:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:17:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:17:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:18:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:18:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:19:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:19:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:21:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:21:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:22:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:22:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:23:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:23:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:24:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:24:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:25:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:25:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:26:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:26:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:28:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:28:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:29:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:29:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:30:2: Mixed spaces and tabs.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:30:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:31:2: Unexpected tab character.
  /Users/milankragujevic/Documents/paratii-lib/lib/paratii.utils.js:31:2: Mixed spaces and tabs.
Milans-MacBook-Air:paratii-lib milankragujevic$ 

Please fix ASAP. Thanks.

standard --version is "10.0.3".

Here is the file in question:
MK_paratii.utils.js.zip

And here is hex:
2018-01-15_023653 paratii utills hexadecimal

I have accidentally discovered that the issue is that standardjs cannot decide whether there should be tabs or spaces and doesn't do anything when it sees tabs and spaces in sequence mixed in a single line.

@LinusU

This comment has been minimized.

Copy link
Member

commented Jan 16, 2018

ESLint says that:

The --fix option on the command line can automatically fix some of the problems reported by this rule.

Potentially the "some" is the problem here. I would recommend opening an issue with them...

ref: https://eslint.org/docs/rules/indent

@joelwallis

This comment has been minimized.

Copy link

commented Mar 25, 2018

Same issue here. So this --fix option is just being passed for eslint then?

@tunnckoCore

This comment has been minimized.

Copy link

commented Mar 26, 2018

@joelwallis yes.

That's good reason to be forced one of the options, here in Standard.
Some final decision is needed. :D

@joelwallis

This comment has been minimized.

Copy link

commented Mar 26, 2018

I spend yesterday looking for a possible solution for it but no luck. I can't even describe reproducible steps because it seem to work in some scenarios but not in others. I could format simple snippets (like echo 'console.log('yay'); | standard --stdin --fix, but not cat file.js | standard --stdin --fix > output.js. Weird!

But if it's being broadcasted to eslint it's probably a bug in it then. I'll keep looking.

@feross

This comment has been minimized.

Copy link
Member

commented May 16, 2018

Every new release of ESLint (and standard) adds more rules that are automatically fixable. standard v11 got a much-improved indent rule, so I'd give that a try and see if it fixes your problems.

Note that not every rule will be automatically fixable -- some will always require a human decision to fix.

@feross feross closed this May 16, 2018

@feross feross added the question label May 16, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.