indentation issue in template literals after upgrading to 11.0.0-beta.0

[egorovli]

Hi.

After upgrading to 11.0.0-beta.0 started to experience weird indentation errors in CSS-in-JS (template literals) syntax. See screenshots attached.

If I set indentation how it wants me to, it gets really weird:

Have to say that I had to upgrade to 11.0.0-beta.0 because of this issue with babel-eslint:

[finnp]

Standard 11 seems to have problems with tagged template strings and indentation. Not sure what changed with eslint. I'll stay with 10 for now.

[ArmorDarks]

Same issue here.

Here it requires 2 spaces for two lines (note that it's for two lines, not for 3):

And here even weirder 4 spaces instead of 12:

[lidel]

I see similar indentation problems with string interpolation and standard v11.0.1 run against this codebase.

standard --fix produces this mess:

index 3ebd809..a593fe2 100644
--- a/add-on/src/popup/page-action/header.js
+++ b/add-on/src/popup/page-action/header.js
@@ -10,12 +10,12 @@ module.exports = function header ({ isIpfsContext, pageActionTitle }) {
     <div class="fade-in ph2 br2 br--top bg-light-gray bb b--black-20">
       <h2 class="ma0 pt1 pb2 pl2 tl">
         ${logo({
-          size: 20,
-          path: '../../../icons',
-          ipfsNodeType: 'external',
-          isIpfsOnline: true,
-          heartbeat: false
-        })} <span class="pl1 f6 fw4 v-mid">${pageActionTitle || '…'}</span>
+    size: 20,
+    path: '../../../icons',
+    ipfsNodeType: 'external',
+    isIpfsOnline: true,
+    heartbeat: false
+  })} <span class="pl1 f6 fw4 v-mid">${pageActionTitle || '…'}</span>
       </h2>
     </div>
   `

Note how line with ${logo({ is left untouched.

[feross]

Wow, this is not good. Will look into fixing this for standard 12

[NathanielHill]

Same problem. In fact, standard --fix is not even idempotent on some of my files using template literals. Saving with auto-linting is interesting to the say the least.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Janpot]

This is kind of blocking me to move past v11. I'm not quite sure how this can be fixed. But maybe this issue should stay open?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[ArmorDarks]

Yeap, definitely stale...

[ArmorDarks]

I wonder why was it closed? It is a critical bug. Or has it been fixed?

[LinusU]

I interpreted your comment to mean that it was fixed, I'd be happy to reopen if it's still a problem in Standard 12...

[ArmorDarks]

As far as I know, it wasn't fixed

[feross]

Sorry for the delay on this issue! Just tested on the latest version. This appears to be fixed. Lmk if that's not the case.

[feross]

Actually, I just tested with another code sample from this issue (#1056) and it seems it's still an issue. Let's move discussion to that issue.