Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README outdated? Expressjs is not using this standard, as far as I can see. #1058

Closed
1602 opened this issue Feb 3, 2018 · 5 comments

Comments

@1602
Copy link

commented Feb 3, 2018

Perhaps, readme could be updated in order to not confuse people (not sure maybe they were using it in the past and then decided to use other standard for some reason). I haven't checked other links, but trust maintainers to cleanup other outdated links (if any).

@dougwilson

This comment has been minimized.

Copy link

commented Feb 3, 2018

Is this a duplicate of #957 ?

@1602

This comment has been minimized.

Copy link
Author

commented Feb 3, 2018

Oops, I missed that one, because it is closed, so it is kind of a duplicate, but bug is still not fixed, not sure why issue #957 closed. As long as .eslintrc of expressjs is different, it is incorrect to state that project is using this standard, maybe in bright future :)

@dougwilson

This comment has been minimized.

Copy link

commented Feb 3, 2018

Yea, like I said in that issue, I'm not sure how the logo got there, but Express rejects all new PRs if they are not in StandardJS style. The express project consists of over 40 repos and almost all of them are 100% in StandardJS style. Since I don't know how the logo got here, I don't know if the intent of the logo is to signify Express as the entire project with all it's repos or if it only refers to a very specific, single repo as it seems you're suggesting.

Clicking the logo does not take me to a single repo so it seems to suggest it refers to the project as a while instead of a single repo. I assume if 1 or 2 repos of npm didn't use StandardJS but every one repo did you'd say that npm logo should be removed too?

@1602

This comment has been minimized.

Copy link
Author

commented Feb 4, 2018

If logo leads to a project with standardjs .eslintrc, than it is fine. Not sure about entire organisations, but I'd say not necessary for all the organisation to be following the standard in all legacy projects, which is kind of silly thing to expect, but what seems like a reasonable expectation is that main project has it (which is express in case of expressjs organisation, for example).

@bcomnes

This comment has been minimized.

Copy link
Member

commented Feb 4, 2018

I'm going to take @dougwilson's word on this one.

@bcomnes bcomnes closed this Feb 4, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.