Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upREADME outdated? Expressjs is not using this standard, as far as I can see. #1058
Comments
This comment has been minimized.
This comment has been minimized.
dougwilson
commented
Feb 3, 2018
|
Is this a duplicate of #957 ? |
This comment has been minimized.
This comment has been minimized.
|
Oops, I missed that one, because it is closed, so it is kind of a duplicate, but bug is still not fixed, not sure why issue #957 closed. As long as .eslintrc of expressjs is different, it is incorrect to state that project is using this standard, maybe in bright future :) |
This comment has been minimized.
This comment has been minimized.
dougwilson
commented
Feb 3, 2018
•
|
Yea, like I said in that issue, I'm not sure how the logo got there, but Express rejects all new PRs if they are not in StandardJS style. The express project consists of over 40 repos and almost all of them are 100% in StandardJS style. Since I don't know how the logo got here, I don't know if the intent of the logo is to signify Express as the entire project with all it's repos or if it only refers to a very specific, single repo as it seems you're suggesting. Clicking the logo does not take me to a single repo so it seems to suggest it refers to the project as a while instead of a single repo. I assume if 1 or 2 repos of npm didn't use StandardJS but every one repo did you'd say that npm logo should be removed too? |
This comment has been minimized.
This comment has been minimized.
|
If logo leads to a project with standardjs .eslintrc, than it is fine. Not sure about entire organisations, but I'd say not necessary for all the organisation to be following the standard in all legacy projects, which is kind of silly thing to expect, but what seems like a reasonable expectation is that main project has it (which is express in case of expressjs organisation, for example). |
This comment has been minimized.
This comment has been minimized.
|
I'm going to take @dougwilson's word on this one. |
1602 commentedFeb 3, 2018
Perhaps, readme could be updated in order to not confuse people (not sure maybe they were using it in the past and then decided to use other standard for some reason). I haven't checked other links, but trust maintainers to cleanup other outdated links (if any).