Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build:dll fails in react-boilerplate project after adding standard or standard@beta #1071

Closed
ShaneMcX opened this issue Feb 19, 2018 · 2 comments

Comments

@ShaneMcX
Copy link

commented Feb 19, 2018

In a fresh react-boilerplate 3.5 project (after running setup), adding standard fails in the build:dll step.

First there are a bunch of warnings, followed by a bunch of errors (see below). Removing standard corrects the issues and build:dll succeeds again.

Are react-boilerplate and standard incompatible, or am I doing something wrong? FWIW, I'm using yarn and this is on MacOS High Sierra.

Since I saw in other issues that the standard beta has a new version of eslint, I tried that, too, with the same results:

$ yarn add standard@beta
yarn add v1.3.2
$ npm run npmcheckversion

> react-boilerplate@3.5.0 npmcheckversion /Users/shane/GitHub/mctunez
> node ./internals/scripts/npmcheckversion.js

[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
[5/5] 📃  Building fresh packages...
success Saved lockfile.
success Saved 18 new dependencies.
├─ chardet@0.4.2
├─ debug-log@1.0.1
├─ deglob@2.1.0
├─ eslint-plugin-promise@3.6.0
├─ eslint-scope@3.7.1
├─ fast-json-stable-stringify@2.0.0
├─ find-root@1.1.0
├─ functional-red-black-tree@1.0.1
├─ ignore@3.3.7
├─ json-parse-better-errors@1.0.1
├─ json-stable-stringify-without-jsonify@1.0.1
├─ pkg-conf@2.1.0
├─ pkg-config@1.1.1
├─ run-parallel@1.1.7
├─ rx-lite-aggregates@4.0.8
├─ rx-lite@4.0.8
├─ standard-engine@7.2.0
└─ standard@11.0.0-beta.0
$ npm run build:dll

> react-boilerplate@3.5.0 build:dll /Users/shane/GitHub/mctunez
> node ./internals/scripts/dependencies.js

Building the Webpack DLL...
Hash: 72e48fe83d4a5f826938
Version: webpack 3.5.5
Time: 4044ms
                      Asset    Size  Chunks                    Chunk Names
reactBoilerplateDeps.dll.js  5.3 MB       0  [emitted]  [big]  reactBoilerplateDeps
chunk    {0} reactBoilerplateDeps.dll.js (reactBoilerplateDeps) 4.54 MB [entry] [rendered]

WARNING in ./node_modules/standard/node_modules/eslint/lib/config/plugins.js
101:25-42 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/standard/node_modules/eslint/lib/config/plugins.js
106:20-45 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/standard/node_modules/eslint/lib/rules.js
118:33-61 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/is-resolvable/index.js
15:4-29 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/require-uncached/index.js
28:8-25 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/pkg-config/index.js
30:12-52 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
700:23-45 Critical dependency: the request of a dependency is an expression

WARNING in ./node_modules/standard/node_modules/eslint/lib/linter.js
773:61-83 Critical dependency: the request of a dependency is an expression

ERROR in ./node_modules/standard/node_modules/eslint/lib/rules.js
Module not found: Error: Can't resolve '../conf/replacements' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib'
 @ ./node_modules/standard/node_modules/eslint/lib/rules.js 14:25-56
 @ ./node_modules/standard/node_modules/eslint/lib/linter.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/deglob/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/deglob'
 @ ./node_modules/deglob/index.js 4:9-22
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/file-entry-cache/cache.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/file-entry-cache'
 @ ./node_modules/file-entry-cache/cache.js 11:13-28
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/find-root/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/find-root'
 @ ./node_modules/find-root/index.js 2:9-22
 @ ./node_modules/deglob/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/fs.realpath/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/fs.realpath'
 @ ./node_modules/fs.realpath/index.js 8:9-22
 @ ./node_modules/glob/glob.js
 @ ./node_modules/deglob/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/fs.realpath/old.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/fs.realpath'
 @ ./node_modules/fs.realpath/old.js 24:9-22
 @ ./node_modules/fs.realpath/index.js
 @ ./node_modules/glob/glob.js
 @ ./node_modules/deglob/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/glob/glob.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/glob'
 @ ./node_modules/glob/glob.js 43:9-22
 @ ./node_modules/deglob/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/glob/sync.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/glob'
 @ ./node_modules/glob/sync.js 4:9-22
 @ ./node_modules/glob/glob.js
 @ ./node_modules/deglob/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/graceful-fs/graceful-fs.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/graceful-fs'
 @ ./node_modules/graceful-fs/graceful-fs.js 1:9-22
 @ ./node_modules/pkg-conf/node_modules/load-json-file/index.js
 @ ./node_modules/pkg-conf/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/graceful-fs/fs.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/graceful-fs'
 @ ./node_modules/graceful-fs/fs.js 3:9-22
 @ ./node_modules/graceful-fs/graceful-fs.js
 @ ./node_modules/pkg-conf/node_modules/load-json-file/index.js
 @ ./node_modules/pkg-conf/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/locate-path/node_modules/path-exists/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/locate-path/node_modules/path-exists'
 @ ./node_modules/locate-path/node_modules/path-exists/index.js 2:11-24
 @ ./node_modules/locate-path/index.js
 @ ./node_modules/find-up/index.js
 @ ./node_modules/pkg-conf/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/mkdirp/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/mkdirp'
 @ ./node_modules/mkdirp/index.js 2:9-22
 @ ./node_modules/write/index.js
 @ ./node_modules/flat-cache/utils.js
 @ ./node_modules/flat-cache/cache.js
 @ ./node_modules/file-entry-cache/cache.js
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/pkg-config/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/pkg-config'
 @ ./node_modules/pkg-config/index.js 6:9-22
 @ ./node_modules/deglob/index.js
 @ ./node_modules/standard-engine/index.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/rimraf/rimraf.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/rimraf'
 @ ./node_modules/rimraf/rimraf.js 6:9-22
 @ ./node_modules/del/index.js
 @ ./node_modules/flat-cache/cache.js
 @ ./node_modules/file-entry-cache/cache.js
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard/node_modules/eslint/lib/load-rules.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib'
 @ ./node_modules/standard/node_modules/eslint/lib/load-rules.js 12:11-24
 @ ./node_modules/standard/node_modules/eslint/lib/rules.js
 @ ./node_modules/standard/node_modules/eslint/lib/linter.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard/node_modules/eslint/lib/ignored-paths.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib'
 @ ./node_modules/standard/node_modules/eslint/lib/ignored-paths.js 12:11-24
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard/node_modules/eslint/lib/file-finder.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib'
 @ ./node_modules/standard/node_modules/eslint/lib/file-finder.js 12:11-24
 @ ./node_modules/standard/node_modules/eslint/lib/config.js
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib'
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js 18:11-24
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard/node_modules/eslint/lib/config/config-file.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib/config'
 @ ./node_modules/standard/node_modules/eslint/lib/config/config-file.js 12:11-24
 @ ./node_modules/standard/node_modules/eslint/lib/config.js
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard/node_modules/eslint/lib/util/glob-util.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib/util'
 @ ./node_modules/standard/node_modules/eslint/lib/util/glob-util.js 11:11-24
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/write/index.js
Module not found: Error: Can't resolve 'fs' in '/Users/shane/GitHub/mctunez/node_modules/write'
 @ ./node_modules/write/index.js 10:9-22
 @ ./node_modules/flat-cache/utils.js
 @ ./node_modules/flat-cache/cache.js
 @ ./node_modules/file-entry-cache/cache.js
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/resolve-from/index.js
Module not found: Error: Can't resolve 'module' in '/Users/shane/GitHub/mctunez/node_modules/resolve-from'
 @ ./node_modules/resolve-from/index.js 3:13-30
 @ ./node_modules/require-uncached/index.js
 @ ./node_modules/standard/node_modules/eslint/lib/config/config-file.js
 @ ./node_modules/standard/node_modules/eslint/lib/config.js
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard/node_modules/eslint/lib/util/module-resolver.js
Module not found: Error: Can't resolve 'module' in '/Users/shane/GitHub/mctunez/node_modules/standard/node_modules/eslint/lib/util'
 @ ./node_modules/standard/node_modules/eslint/lib/util/module-resolver.js 12:15-32
 @ ./node_modules/standard/node_modules/eslint/lib/cli-engine.js
 @ ./node_modules/standard/node_modules/eslint/lib/api.js
 @ ./node_modules/standard/options.js
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps

ERROR in ./node_modules/standard-engine/bin/cmd.js
Module parse failed: /Users/shane/GitHub/mctunez/node_modules/standard-engine/bin/cmd.js Unexpected character '#' (1:0)
You may need an appropriate loader to handle this file type.
| #!/usr/bin/env node
| 
| module.exports = Cli
 @ ./node_modules/standard-engine/index.js 1:21-41
 @ ./node_modules/standard/index.js
 @ dll reactBoilerplateDeps
✨  Done in 15.93s.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 19, 2018 •
edited

It looks like webpack is trying to build standard into your JavaScript bundle. That doesn't seem right... I'm not sure how react-boilerplate is configured that would make it do that.

Can you try removing standard, then installing it as a dev dependency instead of a production dependency?

yarn add standard -D

@feross feross added the need more info label Feb 19, 2018

@ShaneMcX

This comment has been minimized.

Sign in to view
Copy link
Author

commented Feb 21, 2018

Yes, build:dll succeeds after adding standard as a Dev dependency! Thanks!

@ShaneMcX ShaneMcX closed this Feb 21, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
need more info
Milestone
No milestone
2 participants
@ShaneMcX @feross
You can’t perform that action at this time.