Cannot find module 'eslint-plugin-import'

[zeke]

• PR: electron/electronjs.org#1119
• Failing Test https://travis-ci.org/electron/electronjs.org/builds/343168963

standard: Unexpected linter output:
Error: Failed to load plugin import: Cannot find module 'eslint-plugin-import'
Referenced from: /home/travis/build/electron/electronjs.org/node_modules/standard/eslintrc.json
    at Function.Module._resolveFilename (module.js:538:15)
    at Function.resolve (internal/module.js:18:19)
    at Plugins.load (/home/travis/build/electron/electronjs.org/node_modules/eslint/lib/config/plugins.js:106:29)
    at Array.forEach (<anonymous>)
    at Plugins.loadAll (/home/travis/build/electron/electronjs.org/node_modules/eslint/lib/config/plugins.js:146:21)
    at loadFromDisk (/home/travis/build/electron/electronjs.org/node_modules/eslint/lib/config/config-file.js:492:35)
    at load (/home/travis/build/electron/electronjs.org/node_modules/eslint/lib/config/config-file.js:550:20)
    at configExtends.reduceRight (/home/travis/build/electron/electronjs.org/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight (<anonymous>)
    at applyExtends (/home/travis/build/electron/electronjs.org/node_modules/eslint/lib/config/config-file.js:403:28)
If you think this is a bug in `standard`, open an issue: https://github.com/standard/standard/issues

[feross]

This is super odd. We depend on it in package.json here.

I just cloned the branch and tested locally with the exact same version of Node and npm and it worked fine.

I merged master into that PR branch and re-triggered a build. My guess is that it's a race condition npm bug. We'll see if that fixes it.

[feross]

Didn't work. I'm stumped. npm is not installing the deps:

@zkat Do you have any ideas about this? Thanks :)

[zkat]

I'll look at it in more detail tomorrow but: this looks like it's the peerdep hoisting issue. You'll likely have to manually install the missing peerdep at the top level.

tl:dr: npm knows not to hoist peerdeps in some situations but then it turns out it hoists the thing that requires that peerdep. This is not really trivial to fix because it needs a big change to the installer.

But a workaround is that you can just install a matching version of es-plugin-import at the top level and the thing that needs it will now, correctly, have a copy of it.

This bug, afaik, has been around pretty much since npm@3.

[zeke]

Closing, as this appears to have been (perhaps indirectly) resolved in standard@11.0.1

See electron/electronjs.org#1209

[feross]

@zeke Nice to hear!