"react/jsx-no-undef" rule ignores "globals" setting.

[DusanDimitric]

Hi, I'm using standard with react-native and babel-plugin-jsx-control-statements.

Standard version: v11.0.1

Problem

standard shows errors for babel-plugin-jsx-control-statements globals such as If, Choose etc. even though they're declared in package.json standard.globals and the babel-plugin-jsx-control-statements is specified in .babelrc (as seen below)

file: package.json
...
  "standard": {
    "parser": "babel-eslint",
    "globals": [
      "describe",
      "test",
      "it",
      "jest",
      "beforeAll",
      "beforeEach",
      "afterAll",
      "afterEach",
      "expect",
      "fetch",
      "navigator",
      "__DEV__",
      "XMLHttpRequest",
      "FormData",
      "React$Element",
      "If",
      "Choose",
      "When",
      "Otherwise",
      "For",
      "With"
    ]
  }
...

file: .babelrc
...
  "plugins": [
    "jsx-control-statements"
  ],
...

Example output

$ standard --verbose | snazzy
...
  36:14  error  'Choose' is not defined     react/jsx-no-undef
  37:16  error  'When' is not defined       react/jsx-no-undef
  40:16  error  'Otherwise' is not defined  react/jsx-no-undef
  45:12  error  'Choose' is not defined     react/jsx-no-undef
  46:14  error  'When' is not defined       react/jsx-no-undef
  49:14  error  'Otherwise' is not defined  react/jsx-no-undef
  53:12  error  'Choose' is not defined     react/jsx-no-undef
  54:14  error  'When' is not defined       react/jsx-no-undef
  57:14  error  'Otherwise' is not defined  react/jsx-no-undef
...

Expected behavior

standard should not throw react/jsx-no-undef errors for variables declared in package.json > standard.globals:

      "If",
      "Choose",
      "When",
      "Otherwise",
      "For",
      "With"

I've seen this line in the CHANGELOG.md:

Fix jsx-no-undef will not check the global scope by default.

But I guess it doesn't relate to this case.

Let me know if I can provide any more details.
Thanks a lot,
D.D.

[DusanDimitric]

This Important note seems related:

https://github.com/vkbansal/eslint-plugin-jsx-control-statements#important

[DusanDimitric]

Can this react/jsx-no-undef rule be changed so it reads the globals declared in package.json in any way ?

[feross]

@DusanDimitric Yep, we can include this in the next release.

[DusanDimitric]

Thanks ;)

[feross]

I'm going to leave this issue open so that I remember to include this in the next release.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[bovas85]

I can see it's still giving an error here, can we please check this?

[ForkInSpace]

I second this ^