Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git pre-commit hook work with all files but without ignored #1118

Closed
Leesson opened this issue Apr 26, 2018 · 3 comments

Comments

@Leesson
Copy link

commented Apr 26, 2018

Git pre-commit hook demo just work with JSX files for now.
how do i modify it to work with all files but ignore the files or folders that appear in standard.ignore?
(in other words, how git pre-commit hook work with standardjs' configuration in package.json)

@LinusU

This comment has been minimized.

Copy link
Member

commented Apr 26, 2018

The regex should be .jsx? (the ? makes the x optional, thus matching both js and jsx), are you sure it's not working?

@Leesson

This comment has been minimized.

Copy link
Author

commented Apr 27, 2018

Sorry, I did not fully understand it. It did not work well just because I repalced js with es.

@feross

This comment has been minimized.

Copy link
Member

commented Apr 30, 2018

Is this issue resolved? Closing it since it's not clear to me, but feel free to continue discussion.

@feross feross closed this Apr 30, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.