Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNew rule: No unnecessary regex global flags #1152
Comments
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Sep 20, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
label
Sep 20, 2018
This comment has been minimized.
This comment has been minimized.
|
This sounds very nice! @tom-sherman, is there an existing ESLint rule for this? |
stale
bot
removed
the
stale
label
Sep 20, 2018
This comment has been minimized.
This comment has been minimized.
|
@LinusU It doesn't look to be. Should I create an issue in ESlint to discuss adding it? |
This comment has been minimized.
This comment has been minimized.
|
Yes please |
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Dec 19, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
label
Dec 19, 2018
stale
bot
closed this
Dec 26, 2018
lock
bot
locked as resolved and limited conversation to collaborators
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tom-sherman commentedJun 22, 2018
I recently came across an ugly pattern in Regex regarding the
gflag. See here for details: https://stackoverflow.com/questions/2630418/javascript-regex-returning-true-then-false-then-true-etcWould have been nice for the linter to warn that I'm using a global flag when I was using
^and$characters at the beginning and end of the regex.Thoughts?