Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLINT_LEGACY_OBJECT_REST_SPREAD warning w/ latest ESLint #1156

Closed
mikeal opened this issue Jun 24, 2018 · 7 comments

Comments

@mikeal
Copy link

commented Jun 24, 2018

What version of standard?

"eslint-plugin-standard": "^3.1.0"

What operating system, Node.js, and npm version?

Node.js v10

What did you expect to happen?

No warnings or errors.

What actually happened?

ESLint v5.0.0 prints:

(node:41734) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "standard")

@mikeal mikeal changed the title ESLINT_LEGACY_OBJECT_REST_SPREAD Error w/ lates ESLint ESLINT_LEGACY_OBJECT_REST_SPREAD Error w/ latest ESLint Jun 24, 2018

@mikeal mikeal changed the title ESLINT_LEGACY_OBJECT_REST_SPREAD Error w/ latest ESLint ESLINT_LEGACY_OBJECT_REST_SPREAD warning w/ latest ESLint Jun 24, 2018

@mikeal

This comment has been minimized.

Copy link
Author

commented Jun 24, 2018

Sorry about the early post, I hit enter when the test field wasn't in focus and logged the bug earlier than I intended. Fixed everything now.

@sgript

This comment has been minimized.

Copy link

commented Jun 25, 2018

Any more details? Having the same issue on the same standard version.

@Flet

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

Looks like @feross is targeting this to be fixed in the next major version of standard (v12)

eslint-config-standard was updated to fix this last month and released as a v12 alpha:
standard/eslint-config-standard@6a89a51

sticking to standard@11.0.1 which uses eslint@~4.1.18 will avoid this for now.

Otherwise switching to directly use eslint-config-standard@12.0.0-alpha.0 would make it go away.

@feross any plans for a standard@next v12 soon? :)

pcraig3 added a commit to cds-snc/ircc-rescheduler that referenced this issue Jul 26, 2018

Update standard to turf linting error
Found I was getting a linting error when running locally:
> [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "standard")

As noted in a couple places, we can bump the version of our
eslint-config-standard library and we're good.

Source:
- standard/standard#1156
- standard/eslint-config-standard#114

pcraig3 added a commit to cds-snc/ircc-rescheduler that referenced this issue Jul 26, 2018

Update standard to turf linting error
Found I was getting a linting error when running `yarn lint` locally:
> [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "standard")

As noted in a couple places, we can bump the version of our
eslint-config-standard library and we're good.

Source:
- standard/standard#1156
- standard/eslint-config-standard#114

pcraig3 added a commit to cds-snc/ircc-rescheduler that referenced this issue Aug 1, 2018

Update standard to turf linting error
Found I was getting a linting error when running `yarn lint` locally:
> [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "standard")

As noted in a couple places, we can bump the version of our
eslint-config-standard library and we're good.

Source:
- standard/standard#1156
- standard/eslint-config-standard#114

paulmelnikow added a commit to badges/shields that referenced this issue Aug 1, 2018

@paulmelnikow

This comment has been minimized.

Copy link

commented Aug 1, 2018

I've tried using eslint-config-standard@12.0.0-alpha.0 as suggested in #1156 (comment) but I'm running into these related issues with peer dependencies:

I'm hoping @LinusU will be able to move this forward!

(see standard/eslint-config-standard#123 (comment))

paulmelnikow added a commit to badges/shields that referenced this issue Aug 1, 2018

@feross feross added this to the standard v12 milestone Aug 28, 2018

@stale

This comment has been minimized.

Copy link

commented Nov 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 27, 2018

@paulmelnikow

This comment has been minimized.

Copy link

commented Nov 27, 2018

This is fixed in 4.0.0.

@stale stale bot removed the stale label Nov 27, 2018

@stale

This comment has been minimized.

Copy link

commented Feb 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Feb 25, 2019

@stale stale bot closed this Mar 4, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.