Skip to content

/standard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-eslint undefined #1166

Closed
talmobi opened this issue Jul 24, 2018 · 1 comment

Comments

@talmobi
Copy link

commented Jul 24, 2018 •
edited

What version of standard?

11.0.1

What operating system, Node.js, and npm version?

uname -a Darwin Kernel Version 17.6.0
node -v v8.11.2
npm -v 6.1.0

What did you expect to happen?

Globally installed standard to work out of the box npm install -g standard

What actually happened?

An error is thrown: Cannot find module 'babel-eslint' (eslint/undefined)

Related issue: https://github.com/standard/standard/issues/85

According to @feross both standard and babel-eslint needs to be installed (ref: https://github.com/standard/standard/issues/85#issuecomment-391155461).

Then why is babel-eslint only set as a devDependency in the package.json?

Seems like it should be a normal dependency

Installing babel-eslint globally as well resolves the issue: npm install -g babel-eslint

PR: https://github.com/standard/standard/pull/1167

@talmobi talmobi changed the title babel-eslint under babel-eslint undefined Jul 24, 2018

talmobi added a commit to talmobi/standard that referenced this issue Jul 24, 2018

@talmobi
moved `babel-eslint` to dependencies 
`babel-eslint` is now an explicit dependency as opposed only a devDependency like it used to be. Without this change `npm install -g standard` will not work out of the box without also installing `npm install -g babel-eslint`

github issue ref: standard#1166
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9266957
@talmobi talmobi referenced this issue Jul 24, 2018
Closed
@talmobi

This comment has been minimized.

Sign in to view
Copy link
Author

commented Aug 6, 2018

Issue resolved at #1167

Closing.

@talmobi talmobi closed this Aug 6, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@talmobi
You can’t perform that action at this time.