Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert .gitignore? #117

Closed
jprichardson opened this issue Apr 17, 2015 · 2 comments

Comments

@jprichardson
Copy link
Member

commented Apr 17, 2015

Can we consider reverting the .gitignore patch? It doesn't work like people expect, see: #116 & #115.

I'm working on migrating a large project over and my .gitignore is huge. Standard (with .gitignore patch) reports no issues, which is incorrect, because versions before report thousands of lines. What I liked about standard before was that it was super simple to ignore files, just place the patterns in package.json. Now I don't know if it's looking in package.json first and then .gitignore or vice versa. Regardless, it's complicated the whole thing.

I can understand why one would choose .gitignore patterns, but I think we need to either get it near perfect or not at all IMHO.

@feross what are your thoughts?

@feross

This comment has been minimized.

Copy link
Member

commented Apr 17, 2015

I think it won't be too hard to just fix up the .gitignore pattern matching to work correctly. Wouldn't that be the best solution?

We can always apply the package.json ignores after the .gitignore so you have an out if you need to un-ignore something.

@feross

This comment has been minimized.

Copy link
Member

commented Apr 21, 2015

standard@3.7.0 removed support for .gitignore until we can make it work more reliably.

@feross feross closed this Apr 21, 2015

Flet added a commit to Flet/standard that referenced this issue Oct 23, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.