Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Include files using `standard.include` in `package.json` #1177

Closed
danielbankhead opened this issue Aug 11, 2018 · 5 comments

Comments

@danielbankhead
Copy link

commented Aug 11, 2018

What version of standard?
11.0.1

What operating system, Node.js, and npm version?
OS: macOS 10.11.6
Node: 8.11.3
npm: 6.2.0

What did you expect to happen?
A way to include files that were excluded from .gitignore.

What actually happened?
No way to include files from .gitignore

Details
Say you're working on a project that compiles to JavaScript (e.g. TypeScript) and you'd like those distributable files to be formatted in standard, but not committed in your git repo itself. Adding this feature would give a user the flexibility to include files ignored from .gitiginore and standard.ignore.

I'm interested in creating a PR in standard-engine for this feature if you think its a good idea.

@LinusU

This comment has been minimized.

Copy link
Member

commented Aug 11, 2018

Say you're working on a project that compiles to JavaScript (e.g. TypeScript) and you'd like those distributable files to be formatted in standard, but not committed in your git repo itself.

I like this, have a few TypeScript projects myself and would love for them to be standard-style published 🚀

@stale

This comment has been minimized.

Copy link

commented Nov 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 9, 2018

@danielbankhead

This comment has been minimized.

Copy link
Author

commented Nov 14, 2018

Hey @LinusU, I should be able to get to this PR sometime in December. Are you a part of the standard org and/or able to review the PR?

@stale stale bot removed the stale label Nov 14, 2018

@LinusU

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

I will be able to review ☺️

It would be nice to get some signals on what the other maintainers think of the idea, e.g. @feross, @Flet 😀

@stale

This comment has been minimized.

Copy link

commented Feb 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Feb 13, 2019

@stale stale bot closed this Feb 20, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.