Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo support #1182

Open
Janpot opened this issue Aug 25, 2018 · 6 comments

Comments

@Janpot
Copy link

commented Aug 25, 2018

I'd like to reopen #746
We're more than a year and a half later and monorepo structure becomes more and more prevalent. The issue can be easily worked around by ignoring **/node_modules/**. But I think it should be the standard behavior.

@LinusU

This comment has been minimized.

Copy link
Member

commented Aug 27, 2018

Ignoring **/node_modules/ out of the box seems fine by me 👍

@rstacruz

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

I second this, seems like a reasonable thing to do.

For background: the problem stems from a repo structure like so:

/
  packages/
    a/
      node_modules/
    b/
      node_modules/
    c/
      node_modules/

Running standard in the top-level can cause unnecessary traversions down into node_modules/. There's a workaround ☝️, but I agree it makes sense to be default behavior.

@LinusU

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

Pull request very welcome 🙌

@Janpot

This comment has been minimized.

Copy link
Author

commented Aug 28, 2018

Is this default provided by eslint? Maybe it should be a default in eslint?

@brodybits

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2018

I would personally favor consistency with eslint, assuming there is no good reason otherwise.

@Janpot

This comment has been minimized.

Copy link
Author

commented Aug 28, 2018

Yes, that makes sense. I've been digging through their tickets and found this PR eslint/eslint#10092
Not sure whether they're not open to expand the default, or whether it was just easier to document than fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.