Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDisallow self assignment of properties (no-self-assign) #1186
Comments
feross
added this to the standard v12 milestone
Aug 28, 2018
feross
added
the
enhancement
label
Aug 28, 2018
feross
modified the milestones:
standard v12,
standard v14
Jul 5, 2019
feross
closed this
in
757abf0
Jul 27, 2019
This comment has been minimized.
This comment has been minimized.
|
This rule was actually enabled in a prior upgrade of ESLint. I set the option explicitly nonetheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
feross commentedAug 28, 2018
The
no-self-assignrule is already enabled, however in ESLint 5 the default options object for the rule has changed from{ props: false }to{ props: true }.I like this change, so let's keep it, assuming breakage isn't too high.
https://eslint.org/docs/rules/no-self-assign