Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow self assignment of properties (no-self-assign) #1186

Closed
feross opened this issue Aug 28, 2018 · 1 comment

Comments

@feross
Copy link
Member

commented Aug 28, 2018

The no-self-assign rule is already enabled, however in ESLint 5 the default options object for the rule has changed from { props: false } to { props: true }.

I like this change, so let's keep it, assuming breakage isn't too high.

https://eslint.org/docs/rules/no-self-assign

@feross feross added this to the standard v12 milestone Aug 28, 2018

@feross feross added the enhancement label Aug 28, 2018

@feross feross modified the milestones: standard v12, standard v14 Jul 5, 2019

@feross feross closed this in 757abf0 Jul 27, 2019

@feross

This comment has been minimized.

Copy link
Member Author

commented Jul 27, 2019

This rule was actually enabled in a prior upgrade of ESLint. I set the option explicitly nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.