Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upno-new needs exception for Notification api #1197
Comments
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Dec 9, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
stale
label
Dec 9, 2018
stale
bot
closed this
Dec 16, 2018
This comment has been minimized.
This comment has been minimized.
|
@juliangruber sorry that no-one got the time to look at this https://eslint.org/docs/rules/no-new The upstream eslint rule doesn't have any configuration for this, so it would be great if you could open an upstream issue to either add the exception there, or allow a list of exceptions to be passed to the rule. Thanks |
lock
bot
locked as resolved and limited conversation to collaborators
Mar 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
juliangruber commentedSep 10, 2018
•
edited
What version of standard?
12.0.1
What operating system, Node.js, and npm version?
macOS, node v10.9.0, npm 6.2.0
What did you expect to happen?
This should pass standard:
What actually happened?
I got the error
Do not use 'new' for side effects.Since this API is out of my control, I have to introduce a wrapper like this: