Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate errors #12

Closed
Raynos opened this issue Jan 29, 2015 · 6 comments

Comments

@Raynos
Copy link

commented Jan 29, 2015

Since your using three linters your tool will report errors multiple times.

We build a deduplicator into lint-trap cc @malandrew

You may want something similar :D #goodluck

@feross

This comment has been minimized.

Copy link
Member

commented Jan 29, 2015

I'd rather address this by never enabling overlapping rules, i.e. if JSHint is checking that no unused variables exist, then ESLint shouldn't be doing that too. Wouldn't this be a more straightforward way to address the issue?

@Raynos

This comment has been minimized.

Copy link
Author

commented Jan 29, 2015

@feross I think so. I can't remember why we have a dupe map.

@feross

This comment has been minimized.

Copy link
Member

commented Jan 29, 2015

Cool. I'll address duplicates as they come up by relaxing the rules. I've already done this for a few rules.

If anyone runs into any duplicate errors, please run standard --verbose and post the output here. :)

@andrewdeandrade

This comment has been minimized.

Copy link

commented Jan 29, 2015

Dupe map was used because some of the rules were implemented in a subtly different way. Recently, I started removing duplicate rules that I didn't want, and I'm filing issues in eslint to get features into eslint that jscs or jshint have (currently there is only one rule better implemented in jshint versus eslint. one eslint hits parity, I'm going to drop jshint).

The biggest challenge you're going to find with a new linter is not making this project, but building out all the code editor support (SublimeLinter, syntastic, flycheck, etc.). That was the biggest barrier to adoption by co-workers.

Anyways, I'd say to just use lint-trap, but you're probably not going to agree with some of the style choices we made.

@feross

This comment has been minimized.

Copy link
Member

commented Jan 30, 2015

once eslint hits parity, I'm going to drop jshint

Excellent! I'll drop jshint at the same time. Which rule is currently better implemented in jshint?

feross added a commit that referenced this issue Jan 30, 2015

move many rules from jshint to eslint
the goal being to eliminate jshint eventually, see:
#12
@feross

This comment has been minimized.

Copy link
Member

commented Jan 31, 2015

I just removed JSHint entirely. I couldn't find any cases where it caught issues that ESLint missed.

There don't appear to be any more duplicate errors. If anyone notices a duplicate error, please open a new issue.

@feross feross closed this Jan 31, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.