Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.0.1 standard and phpstorm typerror #1212

Closed
AngeIII opened this issue Oct 10, 2018 · 7 comments

Comments

@AngeIII
Copy link

commented Oct 10, 2018

What version of standard?
v12.0.1
What operating system, Node.js, and npm version?
node 10.11.0, npm latest
What did you expect to happen?
no error in phpstorm
What actually happened?
TypeError: globPattern.startsWith is not a function

TypeError: globPattern.startsWith is not a function
at relativize (/home/Data/visualcomposer/node_modules/standard/node_modules/eslint/lib/ignored-paths.js:106:32)
at IgnoredPaths.addPatternRelativeToCwd (/home/Data/visualcomposer/node_modules/standard/node_modules/eslint/lib/ignored-paths.js:249:15)
at new IgnoredPaths (/home/Data/visualcomposer/node_modules/standard/node_modules/eslint/lib/ignored-paths.js:232:22)
at CLIEngine.isPathIgnored (/home/Data/visualcomposer/node_modules/standard/node_modules/eslint/lib/cli-engine.js:638:30)
at ESLintPlugin.getErrors (/home/Apps/PhpStorm-2018.2.4/PhpStorm-182.4505.42/plugins/JavaScriptLanguage/languageService/eslint/bin/eslint-plugin.js:83:23)
at ESLintPlugin.onMessage (/home/Apps/PhpStorm-2018.2.4/PhpStorm-182.4505.42/plugins/JavaScriptLanguage/languageService/eslint/bin/eslint-plugin.js:43:33)
at Interface. (/home/Apps/PhpStorm-2018.2.4/PhpStorm-182.4505.42/plugins/JavaScriptLanguage/jsLanguageServicesImpl/js-language-service.js:105:39)
at Interface.emit (events.js:182:13)
at Interface._onLine (readline.js:290:10)
at Interface._normalWrite (readline.js:433:12)
Process finished with exit code -1

@LinusU

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

eslint/lib/ignored-paths.js:106:32

Seems like this is a problem in ESLint, would you mind opening an issue there? ☺️

@AngeIII

This comment has been minimized.

Copy link
Author

commented Oct 10, 2018

ESlint used by standard package as a dependency and probably standard authors should update their dependency version in order to support newer version of standard+eslint+phpstorm

@AngeIII

This comment has been minimized.

Copy link
Author

commented Oct 10, 2018

Actually, this can be fixed by using yarn and resolutions field. Or just by updating eslint to 5.6.1 (latest)

  "resolutions": {
    "eslint": "5.6.1"
  },
@LinusU

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

Should be fixed by #1210 then 👍

@yf287

This comment has been minimized.

Copy link

commented Nov 12, 2018

I used yarn to resolute eslint at 5.6.1,but still get the error.
I tried to update eslint to lastest version by npm either,and it doesn't work yet.
how can i do

@stale

This comment has been minimized.

Copy link

commented Feb 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Feb 10, 2019

@stale stale bot closed this Feb 17, 2019

@Manu1400

This comment has been minimized.

Copy link

commented Mar 1, 2019

@yf287 see the new eslint ticket: eslint/eslint#11429

@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.