Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'no-unused-vars' outputs errors instead of warnings #1241

Closed
DAmNRelentless opened this issue Jan 19, 2019 · 2 comments

Comments

@DAmNRelentless
Copy link

commented Jan 19, 2019

What version of standard?
1.2.3

What operating system, Node.js, and npm version?
OS: Windows 10 64bit 1809
Node: 10.15.0
npm: 6.4.1

What did you expect to happen?
I expected that StandardJS highlights the unused variables only as warnings and not as errors.

What actually happened?
StandardJS highlights unused variables as errors and not as warning although I changed it to warnings in my .eslintrc.

        "no-unused-vars": [
          "warn",
          {
            "args": "all"
          }
        ]
@LinusU

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

The policy for Standard is to not have any warnings at all and just have errors. This is since warnings often get ignored and won't actually cause any tests to fail, etc.

Why do you feel that no-unused-vars specifically should just be a warning?

@DAmNRelentless

This comment has been minimized.

Copy link
Author

commented Jan 21, 2019

When a project is still in development, I often have vars that are not used yet especially libraries but that will be used later on. So I just need a reminder that I still have this library left and therefor a warning is enough in my opinion. But no worries, if that's the policy, I simply close this issue.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
You can’t perform that action at this time.