Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis build error. CRA react scripts don't want to be friends with standard #1249

Closed
atherdon opened this issue Feb 12, 2019 · 5 comments

Comments

@atherdon
Copy link

commented Feb 12, 2019

What version of standard?
12.0.1
What operating system, Node.js, and npm version?*
Linux, 11.6.0, 6.7.0
What did you expect to happen?
i just find this package and only install it to my CRA project.
What actually happened?
Travis CI trigger a build and notify me about the issue. Details are here: https://travis-ci.org/ChickenKyiv/recipe-antd/jobs/492270612
as per advice from react-scripts test option 7 - I printed a tree of eslint.
this is what i got

│ └─┬ standard@12.0.1
│   ├── eslint@5.4.0
│   └─┬ eslint-plugin-import@2.14.0
│     └── eslint@5.12.0  extraneous
└─┬ react-scripts@2.1.5
  └── eslint@5.12.0

Thank you for your help and awesome tool. I like it!

@atherdon atherdon changed the title travis build error. CRA react scripts don't want to be friends travis build error. CRA react scripts don't want to be friends with standard Feb 12, 2019

@DiegoRBaquero

This comment has been minimized.

Copy link

commented Feb 12, 2019

This seems like a problem of yarn dep tree, did you try:

To fix the dependency tree, try following the steps below in the exact order:

  1. Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
  2. Delete node_modules in your project folder.
  3. Remove "eslint" from dependencies and/or devDependencies in the package.json file in your project folder.
  4. Run npm install or yarn, depending on the package manager you use.
@atherdon

This comment has been minimized.

Copy link
Author

commented Feb 12, 2019

sure i did. this is why i mention that after going to option 7(so i did all suggestions) - i get that printed tree, where standard has eslint5.4 and latest react-scripts has eslint5.12

@stale

This comment has been minimized.

Copy link

commented May 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label May 13, 2019

@stale stale bot closed this May 20, 2019

@feross

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

FYI - StandardJS has upgraded to ESLint v6 which should have resolved this problem.

@atherdon

This comment has been minimized.

Copy link
Author

commented Aug 4, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.